[Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D

2017-02-17 Thread Peter Maydell
Unfortunately some older versions of makeinfo don't correctly handle the -D command line option and fail to set the variable. This then causes them to complain docs/qemu-ga-ref.texi:41: warning: undefined flag: VERSION Work around this by doing as the autotools do, and writing the information int

Re: [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D

2017-02-17 Thread Marc-André Lureau
Hi - Original Message - > Unfortunately some older versions of makeinfo don't correctly > handle the -D command line option and fail to set the variable. > This then causes them to complain > docs/qemu-ga-ref.texi:41: warning: undefined flag: VERSION > > Work around this by doing as the

Re: [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D

2017-02-17 Thread Eric Blake
On 02/17/2017 09:12 AM, Peter Maydell wrote: > Unfortunately some older versions of makeinfo don't correctly > handle the -D command line option and fail to set the variable. > This then causes them to complain > docs/qemu-ga-ref.texi:41: warning: undefined flag: VERSION > > Work around this by d

Re: [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D

2017-02-17 Thread Peter Maydell
On 17 February 2017 at 15:50, Eric Blake wrote: > On 02/17/2017 09:12 AM, Peter Maydell wrote: >> Unfortunately some older versions of makeinfo don't correctly >> handle the -D command line option and fail to set the variable. >> This then causes them to complain >> docs/qemu-ga-ref.texi:41: warn

Re: [Qemu-devel] [PATCH] Makefile: Put VERSION info into version.texi rather than using -D

2017-02-17 Thread Eric Blake
On 02/17/2017 09:52 AM, Peter Maydell wrote: >>> Makefile | 17 ++--- >>> docs/qemu-ga-ref.texi | 2 ++ >>> docs/qemu-qmp-ref.texi | 2 ++ >>> 3 files changed, 14 insertions(+), 7 deletions(-) >> >> Missing a change to .gitignore for version.texi. > > Should be > ---