Re: [Qemu-devel] [PATCH] NVMe: Initial commit

2013-05-28 Thread Kevin Wolf
Am 26.05.2013 um 22:41 hat Keith Busch geschrieben: > On Mon, 27 May 2013, Kevin Wolf wrote: > >Am 10.04.2013 um 22:16 hat Keith Busch geschrieben: > >>Initial commit for emulated nvme pci storage device. Implements the > >>minimum from the specification to work with existing drivers. > >> > >>Cc:

Re: [Qemu-devel] [PATCH] NVMe: Initial commit

2013-05-28 Thread Keith Busch
On Mon, 27 May 2013, Kevin Wolf wrote: Am 10.04.2013 um 22:16 hat Keith Busch geschrieben: Initial commit for emulated nvme pci storage device. Implements the minimum from the specification to work with existing drivers. Cc: Keith Busch Signed-off-by: Keith Busch A lot of people are very int

Re: [Qemu-devel] [PATCH] NVMe: Initial commit

2013-05-27 Thread Kevin Wolf
Am 10.04.2013 um 22:16 hat Keith Busch geschrieben: > Initial commit for emulated nvme pci storage device. Implements the > minimum from the specification to work with existing drivers. > > Cc: Keith Busch > Signed-off-by: Keith Busch > > A lot of people are very interested in this, so I should

Re: [Qemu-devel] [PATCH] NVMe: Initial commit

2013-04-19 Thread Stefan Hajnoczi
On Tue, Apr 2, 2013 at 10:27 PM, Keith Busch wrote: > On Fri, 19 Apr 2013, Stefan Hajnoczi wrote: >> >> I don't see bdrv_aio_flush() in this patch. How does the guest ensure >> that data is safely on persistent storage (e.g. protected against data >> loss by power failure). > > > Great point! Thi

Re: [Qemu-devel] [PATCH] NVMe: Initial commit

2013-04-19 Thread Keith Busch
On Fri, 19 Apr 2013, Stefan Hajnoczi wrote: I don't see bdrv_aio_flush() in this patch. How does the guest ensure that data is safely on persistent storage (e.g. protected against data loss by power failure). Great point! This is to be consistent with the NVMe spec. This commit is the bare min

Re: [Qemu-devel] [PATCH] NVMe: Initial commit

2013-04-19 Thread Stefan Hajnoczi
On Wed, Apr 10, 2013 at 02:16:34PM -0600, Keith Busch wrote: > Initial commit for emulated nvme pci storage device. Implements the > minimum from the specification to work with existing drivers. > > Cc: Keith Busch > Signed-off-by: Keith Busch > > A lot of people are very interested in this, so

Re: [Qemu-devel] [PATCH] NVMe: Initial commit

2013-04-11 Thread Peter Maydell
On 10 April 2013 21:16, Keith Busch wrote: > Initial commit for emulated nvme pci storage device. Implements the > minimum from the specification to work with existing drivers. The commit message could be a little more informative for those who have no idea what an nvme is... > +static const VMS

[Qemu-devel] [PATCH] NVMe: Initial commit

2013-04-10 Thread Keith Busch
Initial commit for emulated nvme pci storage device. Implements the minimum from the specification to work with existing drivers. Cc: Keith Busch Signed-off-by: Keith Busch A lot of people are very interested in this, so I should have more time to dedicate working on submitting this upstream.

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-13 Thread Paolo Bonzini
Il 13/12/2012 10:12, Kevin Wolf ha scritto: >>> There seems to be an issue with the bdrv_aio_[readv/writev] >>> routines. I added some additional tracing in the block and >>> coroutine code, and well, long story short, the coroutine >>> "bdrv_co_io_em" needs to call "qemu_coroutine_yield" before hi

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-13 Thread Kevin Wolf
Am 13.12.2012 01:13, schrieb Busch, Keith: > On Mon, Dec 10, 2012 at 7:11 AM, Stefan Hajnoczi wrote: >> Quick pointers to get started on Kevin's suggestion: >> >> bdrv_aio_readv(), bdrv_aio_writev(), bdrv_aio_flush(), and >> bdrv_aio_discard() provide the block device operations that emulated >> s

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-12 Thread Busch, Keith
On Mon, Dec 10, 2012 at 7:11 AM, Stefan Hajnoczi wrote: > Quick pointers to get started on Kevin's suggestion: > > bdrv_aio_readv(), bdrv_aio_writev(), bdrv_aio_flush(), and > bdrv_aio_discard() provide the block device operations that emulated > storage controllers use. There seems to be an issu

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-10 Thread Busch, Keith
On Mon, Dec 10, 2012 at 7:11 AM, Stefan Hajnoczi wrote: > Quick pointers to get started on Kevin's suggestion: > > bdrv_aio_readv(), bdrv_aio_writev(), bdrv_aio_flush(), and > bdrv_aio_discard() provide the block device operations that emulated > storage controllers use. > > Take a look at hw/vi

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-10 Thread Stefan Hajnoczi
On Mon, Dec 10, 2012 at 1:36 PM, Kevin Wolf wrote: > Hi Keith, > > Am 08.12.2012 20:20, schrieb Keith Busch: >>> IIUC from the website above, NVMe is to be used with SSDs? It would be >>> good to add to the commit message how to actually use the device >>> command-line-wise beyond the obvious -de

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-10 Thread Kevin Wolf
Hi Keith, Am 08.12.2012 20:20, schrieb Keith Busch: >> IIUC from the website above, NVMe is to be used with SSDs? It would be >> good to add to the commit message how to actually use the device >> command-line-wise beyond the obvious -device nvme: I did not spot on >> brief sight where you expose

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-08 Thread Andreas Färber
Am 08.12.2012 20:20, schrieb Keith Busch: > On Sat, Dec 8, 2012 at 10:59 AM, Andreas Färber wrote: >> Generally we encourage people to upstream their devices, given they are >> sufficiently isolated and/or maintainable. > > Yes, that makes sense and have been doing that. We maintain an > upstream

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-08 Thread Keith Busch
On Sat, Dec 8, 2012 at 10:59 AM, Andreas Färber wrote: > Generally we encourage people to upstream their devices, given they are > sufficiently isolated and/or maintainable. Yes, that makes sense and have been doing that. We maintain an upstream repo, but needed to merge with a more recent qemu r

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-08 Thread Andreas Färber
Hi, Am 08.12.2012 01:05, schrieb Keith Busch: > An implementation of a generic NVMe Controller PCI device, developed > from the open standard available at nvmexpress.org. > > Cc: Michael S. Tsirkin > Cc: Keith Busch > Signed-off-by: Keith Busch > --- > I've developed for QEMU for a little whil

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-07 Thread Stefan Weil
Compilation on 32 bit Linux results in lots of warnings caused by wrong format specifiers. Please don't add type casts, but try to use the format specifiers needed (PRIu64, ...). CChw/nvme.o /qemu/hw/nvme.c: In function 'nvme_init_file': /qemu/hw/nvme.c:834:5: error: format '%lu' expects arg

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-07 Thread Stefan Weil
> An implementation of a generic NVMe Controller PCI device, developed > from the open standard available at nvmexpress.org. > > Cc: Michael S. Tsirkin > Cc: Keith Busch > Signed-off-by: Keith Busch > --- > I've developed for QEMU for a little while, but this is my first patch, so > I wouldn't b