Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-13 Thread Kevin Wolf
Am 13.12.2012 01:13, schrieb Busch, Keith: On Mon, Dec 10, 2012 at 7:11 AM, Stefan Hajnoczi stefa...@gmail.com wrote: Quick pointers to get started on Kevin's suggestion: bdrv_aio_readv(), bdrv_aio_writev(), bdrv_aio_flush(), and bdrv_aio_discard() provide the block device operations that

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-13 Thread Paolo Bonzini
Il 13/12/2012 10:12, Kevin Wolf ha scritto: There seems to be an issue with the bdrv_aio_[readv/writev] routines. I added some additional tracing in the block and coroutine code, and well, long story short, the coroutine bdrv_co_io_em needs to call qemu_coroutine_yield before his aio callback

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-12 Thread Busch, Keith
On Mon, Dec 10, 2012 at 7:11 AM, Stefan Hajnoczi stefa...@gmail.com wrote: Quick pointers to get started on Kevin's suggestion: bdrv_aio_readv(), bdrv_aio_writev(), bdrv_aio_flush(), and bdrv_aio_discard() provide the block device operations that emulated storage controllers use. There seems

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-10 Thread Kevin Wolf
Hi Keith, Am 08.12.2012 20:20, schrieb Keith Busch: IIUC from the website above, NVMe is to be used with SSDs? It would be good to add to the commit message how to actually use the device command-line-wise beyond the obvious -device nvme: I did not spot on brief sight where you expose a bus

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-10 Thread Stefan Hajnoczi
On Mon, Dec 10, 2012 at 1:36 PM, Kevin Wolf kw...@redhat.com wrote: Hi Keith, Am 08.12.2012 20:20, schrieb Keith Busch: IIUC from the website above, NVMe is to be used with SSDs? It would be good to add to the commit message how to actually use the device command-line-wise beyond the

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-10 Thread Busch, Keith
On Mon, Dec 10, 2012 at 7:11 AM, Stefan Hajnoczi stefa...@gmail.com wrote: Quick pointers to get started on Kevin's suggestion: bdrv_aio_readv(), bdrv_aio_writev(), bdrv_aio_flush(), and bdrv_aio_discard() provide the block device operations that emulated storage controllers use. Take a

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-08 Thread Andreas Färber
Hi, Am 08.12.2012 01:05, schrieb Keith Busch: An implementation of a generic NVMe Controller PCI device, developed from the open standard available at nvmexpress.org. Cc: Michael S. Tsirkin m...@redhat.com Cc: Keith Busch keith.bu...@gmail.com Signed-off-by: Keith Busch

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-08 Thread Keith Busch
On Sat, Dec 8, 2012 at 10:59 AM, Andreas Färber afaer...@suse.de wrote: Generally we encourage people to upstream their devices, given they are sufficiently isolated and/or maintainable. Yes, that makes sense and have been doing that. We maintain an upstream repo, but needed to merge with a

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-08 Thread Andreas Färber
Am 08.12.2012 20:20, schrieb Keith Busch: On Sat, Dec 8, 2012 at 10:59 AM, Andreas Färber afaer...@suse.de wrote: Generally we encourage people to upstream their devices, given they are sufficiently isolated and/or maintainable. Yes, that makes sense and have been doing that. We maintain an

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-07 Thread Stefan Weil
An implementation of a generic NVMe Controller PCI device, developed from the open standard available at nvmexpress.org. Cc: Michael S. Tsirkin m...@redhat.com Cc: Keith Busch keith.bu...@gmail.com Signed-off-by: Keith Busch keith.bu...@intel.com --- I've developed for QEMU for a little

Re: [Qemu-devel] [PATCH] NVMe: Initial commit to add an NVM Express device

2012-12-07 Thread Stefan Weil
Compilation on 32 bit Linux results in lots of warnings caused by wrong format specifiers. Please don't add type casts, but try to use the format specifiers needed (PRIu64, ...). CChw/nvme.o /qemu/hw/nvme.c: In function 'nvme_init_file': /qemu/hw/nvme.c:834:5: error: format '%lu' expects