Re: [Qemu-devel] [PATCH] all vga: refuse hotplugging.

2010-05-31 Thread Gerd Hoffmann
On 05/28/10 16:21, Paul Brook wrote: Try to pci hotplug a vga card, watch qemu die with hw_error(). This patch fixes it. I think this is wrong. There's no reason why VGA adapters shouldn't be hotplugged. You should fix the underlying problems that prevent hotplugging The qemu code base simpl

Re: [Qemu-devel] [PATCH] all vga: refuse hotplugging.

2010-05-28 Thread Paul Brook
> Try to pci hotplug a vga card, watch qemu die with hw_error(). > This patch fixes it. I think this is wrong. There's no reason why VGA adapters shouldn't be hotplugged. You should fix the underlying problems that prevent hotplugging (or make them fail gracefully). Paul

Re: [Qemu-devel] [PATCH] all vga: refuse hotplugging.

2010-05-26 Thread Gerd Hoffmann
Hi, I think having two gfx screens mapped to two qemu consoles, then be able to switch between them via Ctrl-Alt- (like you switch today to text consoles) could be doable without too much effort. Question is how useful this would be as you can't see your two screens at the same time. Actua

Re: [Qemu-devel] [PATCH] all vga: refuse hotplugging.

2010-05-26 Thread Stefano Stabellini
On Wed, 26 May 2010, Gerd Hoffmann wrote: >Hi, > > >> Yes. Assuming the virtual hardware in question can actually act as > >> secondary, i.e. is fully programmable without the legacy vga ports. The > >> standard vga can't. The cirrus looks doable, at least you can access > >> the vga ports

Re: [Qemu-devel] [PATCH] all vga: refuse hotplugging.

2010-05-26 Thread Gerd Hoffmann
Hi, Yes. Assuming the virtual hardware in question can actually act as secondary, i.e. is fully programmable without the legacy vga ports. The standard vga can't. The cirrus looks doable, at least you can access the vga ports using the mmio bar. I see, good point. I guess the right fix h

Re: [Qemu-devel] [PATCH] all vga: refuse hotplugging.

2010-05-26 Thread Stefano Stabellini
On Wed, 26 May 2010, Gerd Hoffmann wrote: > On 05/26/10 12:59, Stefano Stabellini wrote: > > On Wed, 26 May 2010, Gerd Hoffmann wrote: > >> Try to pci hotplug a vga card, watch qemu die with hw_error(). > >> This patch fixes it. > >> > > > > Do you know the reason why we get hw_error()? > > Becaus

Re: [Qemu-devel] [PATCH] all vga: refuse hotplugging.

2010-05-26 Thread Gerd Hoffmann
On 05/26/10 12:59, Stefano Stabellini wrote: On Wed, 26 May 2010, Gerd Hoffmann wrote: Try to pci hotplug a vga card, watch qemu die with hw_error(). This patch fixes it. Do you know the reason why we get hw_error()? Because the card tries to register the legacy vga ports which are already

Re: [Qemu-devel] [PATCH] all vga: refuse hotplugging.

2010-05-26 Thread Stefano Stabellini
On Wed, 26 May 2010, Gerd Hoffmann wrote: > Try to pci hotplug a vga card, watch qemu die with hw_error(). > This patch fixes it. > Do you know the reason why we get hw_error()? Theoretically vga hotplug should be possible at least for secondary graphic cards (even though I suspect most operating

[Qemu-devel] [PATCH] all vga: refuse hotplugging.

2010-05-26 Thread Gerd Hoffmann
Try to pci hotplug a vga card, watch qemu die with hw_error(). This patch fixes it. Signed-off-by: Gerd Hoffmann --- hw/cirrus_vga.c |4 hw/vga-pci.c|4 hw/vmware_vga.c |4 3 files changed, 12 insertions(+), 0 deletions(-) diff --git a/hw/cirrus_vga.c b/hw/cirrus_