Re: [Qemu-devel] [PATCH] arm: soc-dma: use hwaddr instead of target_ulong in printf

2015-12-15 Thread Paolo Bonzini
On 15/12/2015 12:28, Peter Maydell wrote: > Now in target-arm.next. I also did s/__FUNCTION__/__func__/ > since checkpatch complains about it and we're touching these lines > of code anyway. Thanks! Paolo

Re: [Qemu-devel] [PATCH] arm: soc-dma: use hwaddr instead of target_ulong in printf

2015-12-15 Thread Peter Maydell
On 4 December 2015 at 16:52, Peter Maydell wrote: > On 4 December 2015 at 16:39, Paolo Bonzini wrote: >> >>> I don't think we've ever said "we should transition away from HWADDR_*", >>> but whether we should is an interesting question, which is why I asked. >>> Does retaining the format macros to

Re: [Qemu-devel] [PATCH] arm: soc-dma: use hwaddr instead of target_ulong in printf

2015-12-04 Thread Peter Maydell
On 4 December 2015 at 16:39, Paolo Bonzini wrote: > >> I don't think we've ever said "we should transition away from HWADDR_*", >> but whether we should is an interesting question, which is why I asked. >> Does retaining the format macros to go with the typedef give us >> useful flexibility, or is

Re: [Qemu-devel] [PATCH] arm: soc-dma: use hwaddr instead of target_ulong in printf

2015-12-04 Thread Paolo Bonzini
> I don't think we've ever said "we should transition away from HWADDR_*", > but whether we should is an interesting question, which is why I asked. > Does retaining the format macros to go with the typedef give us > useful flexibility, or is it just confusing? I think it's confusing, but not eno

Re: [Qemu-devel] [PATCH] arm: soc-dma: use hwaddr instead of target_ulong in printf

2015-12-04 Thread Peter Maydell
On 4 December 2015 at 12:36, Paolo Bonzini wrote: > > > On 04/12/2015 13:33, Peter Maydell wrote: >> On 4 December 2015 at 12:28, Paolo Bonzini wrote: >>> This is a first baby step towards removing widespread inclusion of >>> cpu.h and compiling more devices once (so that arm, aarch64 and >>> in

Re: [Qemu-devel] [PATCH] arm: soc-dma: use hwaddr instead of target_ulong in printf

2015-12-04 Thread Markus Armbruster
Paolo Bonzini writes: > This is a first baby step towards removing widespread inclusion of > cpu.h and compiling more devices once (so that arm, aarch64 and > in the future target-multi can share the object files). Sounds like something that should be covered in http://qemu-project.org/CodeTrans

Re: [Qemu-devel] [PATCH] arm: soc-dma: use hwaddr instead of target_ulong in printf

2015-12-04 Thread Paolo Bonzini
On 04/12/2015 13:33, Peter Maydell wrote: > On 4 December 2015 at 12:28, Paolo Bonzini wrote: >> This is a first baby step towards removing widespread inclusion of >> cpu.h and compiling more devices once (so that arm, aarch64 and >> in the future target-multi can share the object files). >> >>

Re: [Qemu-devel] [PATCH] arm: soc-dma: use hwaddr instead of target_ulong in printf

2015-12-04 Thread Peter Maydell
On 4 December 2015 at 12:28, Paolo Bonzini wrote: > This is a first baby step towards removing widespread inclusion of > cpu.h and compiling more devices once (so that arm, aarch64 and > in the future target-multi can share the object files). > > Signed-off-by: Paolo Bonzini > --- > hw/dma/soc_d

[Qemu-devel] [PATCH] arm: soc-dma: use hwaddr instead of target_ulong in printf

2015-12-04 Thread Paolo Bonzini
This is a first baby step towards removing widespread inclusion of cpu.h and compiling more devices once (so that arm, aarch64 and in the future target-multi can share the object files). Signed-off-by: Paolo Bonzini --- hw/dma/soc_dma.c | 37 - 1 file changed,