Re: [Qemu-devel] [PATCH] bitops.h: Remove unused bitops function test_and_change_bit()

2019-04-03 Thread Zhang, Chen
> -Original Message- > From: Peter Maydell [mailto:peter.mayd...@linaro.org] > Sent: Thursday, April 4, 2019 9:43 AM > To: Zhang, Chen > Cc: Dr. David Alan Gilbert ; qemu-dev de...@nongnu.org>; John Snow ; Fam Zheng > > Subject: Re: [Qemu-devel] [PATCH] bitops

Re: [Qemu-devel] [PATCH] bitops.h: Remove unused bitops function test_and_change_bit()

2019-04-03 Thread Peter Maydell
On Sat, 30 Mar 2019 at 03:09, Zhang Chen wrote: > > From: Zhang Chen > > In current codes we use change_bit() to finish the job. > > Signed-off-by: Zhang Chen > --- > include/qemu/bitmap.h | 1 - > include/qemu/bitops.h | 15 --- > 2 files changed, 16 deletions(-) Do we gain anyth

Re: [Qemu-devel] [PATCH] bitops.h: Remove unused bitops function test_and_change_bit()

2019-04-03 Thread John Snow
On 3/29/19 4:04 PM, Zhang Chen wrote: > From: Zhang Chen > > In current codes we use change_bit() to finish the job. > > Signed-off-by: Zhang Chen > --- > include/qemu/bitmap.h | 1 - > include/qemu/bitops.h | 15 --- > 2 files changed, 16 deletions(-) > > diff --git a/include

Re: [Qemu-devel] [PATCH] bitops.h: Remove unused bitops function test_and_change_bit()

2019-03-29 Thread Zhang, Chen
About this patch, do we need merge similar function as one with return value? For example: test_and_set_bit()/set_bit(), test_and_clear_bit()/clear_bit(). Thanks Zhang Chen > -Original Message- > From: Zhang, Chen > Sent: Saturday, March 30, 2019 4:05 AM > To: Dr. David Alan Gilbert ; qem

[Qemu-devel] [PATCH] bitops.h: Remove unused bitops function test_and_change_bit()

2019-03-29 Thread Zhang Chen
From: Zhang Chen In current codes we use change_bit() to finish the job. Signed-off-by: Zhang Chen --- include/qemu/bitmap.h | 1 - include/qemu/bitops.h | 15 --- 2 files changed, 16 deletions(-) diff --git a/include/qemu/bitmap.h b/include/qemu/bitmap.h index 5c313346b9..6b71ef