Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-07-31 Thread Peter Maydell
On 23 July 2012 15:21, Peter Maydell wrote: > On 29 June 2012 15:04, Anthony Liguori wrote: >> On 06/28/2012 12:51 PM, Peter Maydell wrote: >>> On 20 June 2012 15:44, Anthony Liguori wrote: This avoids the problem associated with having multiple target specific files in a single direct

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-07-23 Thread Peter Maydell
On 29 June 2012 15:04, Anthony Liguori wrote: > On 06/28/2012 12:51 PM, Peter Maydell wrote: >> On 20 June 2012 15:44, Anthony Liguori wrote: >>> This avoids the problem associated with having multiple target specific >>> files in a single directory with the current build system. >>> >>> We can e

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-07-01 Thread Paolo Bonzini
Il 29/06/2012 14:31, Andreas Färber ha scritto: >> > Ping? I can't figure out if this discussion got wedged (in which >> > case, how should it be unwedged?) or if people were eventually happy >> > with this patch... > My guess is we're waiting for Paolo to return from vacation and to > comment. Bas

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-07-01 Thread Peter Maydell
On 1 July 2012 14:37, Paolo Bonzini wrote: > Il 23/06/2012 12:30, Peter Maydell ha scritto: >>> > Can't it go in hw/arm/kvm (mimicking the final desired place, which >>> > will be target-arm/hw/kvm)? And hw/kvm can be moved to hw/i386/kvm, or >>> > we can leave it there for now until we're ready t

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-07-01 Thread Paolo Bonzini
Il 23/06/2012 12:30, Peter Maydell ha scritto: >> > Can't it go in hw/arm/kvm (mimicking the final desired place, which >> > will be target-arm/hw/kvm)? And hw/kvm can be moved to hw/i386/kvm, or >> > we can leave it there for now until we're ready to move it to >> > target-i386/hw/kvm. > Why's the

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-06-29 Thread Anthony Liguori
On 06/28/2012 12:51 PM, Peter Maydell wrote: On 20 June 2012 15:44, Anthony Liguori wrote: This avoids the problem associated with having multiple target specific files in a single directory with the current build system. We can eventually get rid of the hw/$BASE_ARCH/Makefiles.obj files too

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-06-29 Thread Andreas Färber
Am 28.06.2012 19:51, schrieb Peter Maydell: > On 20 June 2012 15:44, Anthony Liguori wrote: >> This avoids the problem associated with having multiple target specific files >> in a single directory with the current build system. >> >> We can eventually get rid of the hw/$BASE_ARCH/Makefiles.obj fi

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-06-28 Thread Peter Maydell
On 20 June 2012 15:44, Anthony Liguori wrote: > This avoids the problem associated with having multiple target specific files > in a single directory with the current build system. > > We can eventually get rid of the hw/$BASE_ARCH/Makefiles.obj files too Ping? I can't figure out if this discussi

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-06-23 Thread Peter Maydell
On 23 June 2012 08:53, Paolo Bonzini wrote: >> Peter's got an ARM specific KVM device he wants to stick in hw/kvm. > > Can't it go in hw/arm/kvm (mimicking the final desired place, which > will be target-arm/hw/kvm)? And hw/kvm can be moved to hw/i386/kvm, or > we can leave it there for now until

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-06-23 Thread Paolo Bonzini
> What is exactly the problem? > > Peter's got an ARM specific KVM device he wants to stick in hw/kvm. Can't it go in hw/arm/kvm (mimicking the final desired place, which will be target-arm/hw/kvm)? And hw/kvm can be moved to hw/i386/kvm, or we can leave it there for now until we're ready to m

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-06-21 Thread Anthony Liguori
On 06/21/2012 07:31 AM, Paolo Bonzini wrote: (Sorry for breaking the thread). This avoids the problem associated with having multiple target specific files in a single directory with the current build system. What is exactly the problem? Peter's got an ARM specific KVM device he wants to st

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-06-21 Thread Paolo Bonzini
(Sorry for breaking the thread). > This avoids the problem associated with having multiple target specific files > in a single directory with the current build system. What is exactly the problem? I saw something about dependencies, I think that should be solved with something like $(foreach va

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-06-20 Thread Anthony Liguori
On 06/20/2012 09:51 AM, Andreas Färber wrote: Am 20.06.2012 16:44, schrieb Anthony Liguori: diff --git a/hw/kvm/Makefile.objs b/hw/kvm/Makefile.objs index 226497a..cf734ba 100644 --- a/hw/kvm/Makefile.objs +++ b/hw/kvm/Makefile.objs @@ -1 +1 @@ -obj-$(CONFIG_KVM) += clock.o apic.o i8259.o ioapic

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-06-20 Thread Andreas Färber
Am 20.06.2012 17:07, schrieb Peter Maydell: > On 20 June 2012 16:04, Andreas Färber wrote: >> Am 20.06.2012 17:01, schrieb Peter Maydell: >>> I'm confused -- as far as I can tell these files are compiled per >>> target, eg we have both >>> CCi386-softmmu/hw/kvm/clock.o >>> and >>> CCx8

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-06-20 Thread Peter Maydell
On 20 June 2012 15:44, Anthony Liguori wrote: > This avoids the problem associated with having multiple target specific files > in a single directory with the current build system. > > We can eventually get rid of the hw/$BASE_ARCH/Makefiles.obj files too > > Signed-off-by: Anthony Liguori > ---

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-06-20 Thread Peter Maydell
On 20 June 2012 16:04, Andreas Färber wrote: > Am 20.06.2012 17:01, schrieb Peter Maydell: >> I'm confused -- as far as I can tell these files are compiled per >> target, eg we have both >>   CC    i386-softmmu/hw/kvm/clock.o >> and >>   CC    x86_64-softmmu/hw/kvm/clock.o > > Currently yes, but w

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-06-20 Thread Andreas Färber
Am 20.06.2012 17:01, schrieb Peter Maydell: > On 20 June 2012 15:51, Andreas Färber wrote: >> Am 20.06.2012 16:44, schrieb Anthony Liguori: >>> --- a/hw/kvm/Makefile.objs >>> +++ b/hw/kvm/Makefile.objs >>> @@ -1 +1 @@ >>> -obj-$(CONFIG_KVM) += clock.o apic.o i8259.o ioapic.o i8254.o >>> +obj-$(CON

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-06-20 Thread Peter Maydell
On 20 June 2012 15:51, Andreas Färber wrote: > Am 20.06.2012 16:44, schrieb Anthony Liguori: >> --- a/hw/kvm/Makefile.objs >> +++ b/hw/kvm/Makefile.objs >> @@ -1 +1 @@ >> -obj-$(CONFIG_KVM) += clock.o apic.o i8259.o ioapic.o i8254.o >> +obj-$(CONFIG_I386) += clock.o apic.o i8259.o ioapic.o i8254.o

[Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-06-20 Thread Anthony Liguori
This avoids the problem associated with having multiple target specific files in a single directory with the current build system. We can eventually get rid of the hw/$BASE_ARCH/Makefiles.obj files too Signed-off-by: Anthony Liguori --- I tried to add a nice comment to the config-target.mak that

Re: [Qemu-devel] [PATCH] build: introduce target CONFIG_ variables and use them for kvm

2012-06-20 Thread Andreas Färber
Am 20.06.2012 16:44, schrieb Anthony Liguori: > This avoids the problem associated with having multiple target specific files > in a single directory with the current build system. > > We can eventually get rid of the hw/$BASE_ARCH/Makefiles.obj files too > > Signed-off-by: Anthony Liguori > ---