Re: [Qemu-devel] [PATCH] configure: Always build with -fno-common

2014-03-06 Thread Peter Maydell
On 28 February 2014 17:19, Richard Henderson r...@twiddle.net wrote: On 02/26/2014 01:53 PM, Peter Maydell wrote: In QEMU we don't make any use at all of the common symbol functionality, so we can avoid this problem entirely simply by compiling with -fno-common. Enable this option for all

Re: [Qemu-devel] [PATCH] configure: Always build with -fno-common

2014-02-28 Thread Richard Henderson
On 02/26/2014 01:53 PM, Peter Maydell wrote: In QEMU we don't make any use at all of the common symbol functionality, so we can avoid this problem entirely simply by compiling with -fno-common. Enable this option for all builds, not just MacOSX, so that if we ever inadvertently introduce

[Qemu-devel] [PATCH] configure: Always build with -fno-common

2014-02-26 Thread Peter Maydell
MacOSX doesn't pull .o files from .a archives if the symbol that it requires is one which the .o file defines as a common symbol. (Common symbols are those declared without extern; the linker will merge together common symbols with the same name, so redeclaring the same variable in two compilation