Re: [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system

2019-05-15 Thread Aleksandar Markovic
On May 15, 2019 12:07 PM, "Peter Maydell" wrote: > > On Tue, 14 May 2019 at 20:16, Aleksandar Markovic > wrote: > > > > On May 13, 2019 11:14 PM, "Richard Henderson" < richard.hender...@linaro.org> > > wrote: > > > > > > On 5/11/19 5:47 AM, Aleksandar Markovic wrote: > > > > If no, the patch

Re: [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system

2019-05-15 Thread Peter Maydell
On Tue, 14 May 2019 at 20:16, Aleksandar Markovic wrote: > > On May 13, 2019 11:14 PM, "Richard Henderson" > wrote: > > > > On 5/11/19 5:47 AM, Aleksandar Markovic wrote: > > > If no, the patch shoud be amended. If yes, the commit message should be > > > extended. > > > > Like what? I think

Re: [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system

2019-05-14 Thread Aleksandar Markovic
On May 13, 2019 11:14 PM, "Richard Henderson" wrote: > > On 5/11/19 5:47 AM, Aleksandar Markovic wrote: > > > > On May 10, 2019 10:36 PM, "Richard Henderson" < richard.hender...@linaro.org > > > wrote: > >> > >> For linux-user, there is no need to add slirp to

Re: [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system

2019-05-13 Thread Richard Henderson
On 5/11/19 5:47 AM, Aleksandar Markovic wrote: > > On May 10, 2019 10:36 PM, "Richard Henderson" > wrote: >> >> For linux-user, there is no need to add slirp to the set of >> git modules checked out, nor build it. >> >> This also avoids a makefile bug wrt

Re: [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system

2019-05-11 Thread Aleksandar Markovic
On May 10, 2019 10:36 PM, "Richard Henderson" wrote: > > For linux-user, there is no need to add slirp to the set of > git modules checked out, nor build it. > > This also avoids a makefile bug wrt insufficient dependencies > on subdir-slirp. If slirp/ is not initially present, the >

Re: [Qemu-devel] [PATCH] configure: Disable slirp if --disable-system

2019-05-11 Thread Thomas Huth
On 10/05/2019 22.34, Richard Henderson wrote: > For linux-user, there is no need to add slirp to the set of > git modules checked out, nor build it. > > This also avoids a makefile bug wrt insufficient dependencies > on subdir-slirp. If slirp/ is not initially present, the > dependencies that

[Qemu-devel] [PATCH] configure: Disable slirp if --disable-system

2019-05-10 Thread Richard Henderson
For linux-user, there is no need to add slirp to the set of git modules checked out, nor build it. This also avoids a makefile bug wrt insufficient dependencies on subdir-slirp. If slirp/ is not initially present, the dependencies that check it out are associated with softmmu, which then