Re: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator

2018-01-08 Thread Peter Maydell
On 8 January 2018 at 17:16, Philippe Mathieu-Daudé wrote: > On 01/08/2018 02:10 PM, Peter Maydell wrote: >> In commit c97d6d2cdf97ed we accidentally added code to configure >> that uses '==' for string equality testing. This is a bashism -- >> the portable way to write this is '='. >> >> This fixe

Re: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator

2018-01-08 Thread Philippe Mathieu-Daudé
On 01/08/2018 02:10 PM, Peter Maydell wrote: > In commit c97d6d2cdf97ed we accidentally added code to configure > that uses '==' for string equality testing. This is a bashism -- > the portable way to write this is '='. > > This fixes the "Unexpected operator error" complaint produced > if the sys

Re: [Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator

2018-01-08 Thread Eric Blake
On 01/08/2018 11:10 AM, Peter Maydell wrote: > In commit c97d6d2cdf97ed we accidentally added code to configure > that uses '==' for string equality testing. This is a bashism -- > the portable way to write this is '='. > > This fixes the "Unexpected operator error" complaint produced > if the sys

[Qemu-devel] [PATCH] configure: Fix incorrect string comparison operator

2018-01-08 Thread Peter Maydell
In commit c97d6d2cdf97ed we accidentally added code to configure that uses '==' for string equality testing. This is a bashism -- the portable way to write this is '='. This fixes the "Unexpected operator error" complaint produced if the system /bin/sh is dash. Fixes: c97d6d2cdf97ed Reported-by: