Re: [Qemu-devel] [PATCH] configure: Unify arm and aarch64 disas configury

2015-06-08 Thread Peter Maydell
On 7 June 2015 at 20:19, Peter Crosthwaite wrote: > On Sun, Jun 7, 2015 at 3:51 AM, Peter Maydell > wrote: >> worked when I looked at it :-) We'd get duplicate lines in >> the config files, but we already have those when host==target. >> > > Brute force it and sort -u? sort is considered a core

Re: [Qemu-devel] [PATCH] configure: Unify arm and aarch64 disas configury

2015-06-07 Thread Peter Crosthwaite
On Sun, Jun 7, 2015 at 3:51 AM, Peter Maydell wrote: > On 7 June 2015 at 09:49, Peter Crosthwaite > wrote: >> OK I am at the bottom of it. The case statement only handles the base >> arch and the host arch not the actual target arch. > > Aha. > >> This means the >> "arm)" case is all that is cal

Re: [Qemu-devel] [PATCH] configure: Unify arm and aarch64 disas configury

2015-06-07 Thread Peter Maydell
On 7 June 2015 at 09:49, Peter Crosthwaite wrote: > OK I am at the bottom of it. The case statement only handles the base > arch and the host arch not the actual target arch. Aha. > This means the > "arm)" case is all that is called for aarch64 target. the "aarch64)" > case in existing code is p

Re: [Qemu-devel] [PATCH] configure: Unify arm and aarch64 disas configury

2015-06-07 Thread Peter Crosthwaite
On Tue, May 26, 2015 at 1:24 AM, Peter Maydell wrote: > On 26 May 2015 at 09:01, Peter Crosthwaite > wrote: >> On Tue, May 26, 2015 at 12:18 AM, Peter Maydell >> wrote: >>> On 26 May 2015 at 06:49, Peter Crosthwaite >>> wrote: From: Peter Crosthwaite The "arm" variant for this

Re: [Qemu-devel] [PATCH] configure: Unify arm and aarch64 disas configury

2015-05-26 Thread Peter Maydell
On 26 May 2015 at 09:01, Peter Crosthwaite wrote: > On Tue, May 26, 2015 at 12:18 AM, Peter Maydell > wrote: >> On 26 May 2015 at 06:49, Peter Crosthwaite >> wrote: >>> From: Peter Crosthwaite >>> >>> The "arm" variant for this case already contains everything needed >>> for aarch64. As aarch6

Re: [Qemu-devel] [PATCH] configure: Unify arm and aarch64 disas configury

2015-05-26 Thread Peter Crosthwaite
On Tue, May 26, 2015 at 12:18 AM, Peter Maydell wrote: > On 26 May 2015 at 06:49, Peter Crosthwaite wrote: >> From: Peter Crosthwaite >> >> The "arm" variant for this case already contains everything needed >> for aarch64. As aarch64 already uses arm as a base architecture, it >> will already ha

Re: [Qemu-devel] [PATCH] configure: Unify arm and aarch64 disas configury

2015-05-26 Thread Peter Maydell
On 26 May 2015 at 06:49, Peter Crosthwaite wrote: > From: Peter Crosthwaite > > The "arm" variant for this case already contains everything needed > for aarch64. As aarch64 already uses arm as a base architecture, it > will already have the CONFIG_ARM_DIS defined meaning no functional > change. S

[Qemu-devel] [PATCH] configure: Unify arm and aarch64 disas configury

2015-05-25 Thread Peter Crosthwaite
From: Peter Crosthwaite The "arm" variant for this case already contains everything needed for aarch64. As aarch64 already uses arm as a base architecture, it will already have the CONFIG_ARM_DIS defined meaning no functional change. So just make the configure code simpler. Following this patch: