Re: [Qemu-devel] [PATCH] configure: Use strings command from cross development tools

2018-05-15 Thread Eric Blake
On 05/15/2018 10:04 AM, Peter Maydell wrote: I'd much prefer this to be: if $strings -a $TMPO | grep... That's because if I have something like this in my environment: STRINGS='/path/to/strings -a' it will only work if you allow word splitting on my variable. Conversely, if I have STRINGS=

Re: [Qemu-devel] [PATCH] configure: Use strings command from cross development tools

2018-05-15 Thread Peter Maydell
On 15 May 2018 at 16:00, Eric Blake wrote: > On 05/13/2018 03:50 AM, Stefan Weil wrote: >> >> This fixes cross builds for the (rare) case where cross binutils >> but no native binutils are installed. >> >> Signed-off-by: Stefan Weil >> --- >> configure | 5 +++-- >> 1 file changed, 3 insertion

Re: [Qemu-devel] [PATCH] configure: Use strings command from cross development tools

2018-05-15 Thread Eric Blake
On 05/13/2018 03:50 AM, Stefan Weil wrote: This fixes cross builds for the (rare) case where cross binutils but no native binutils are installed. Signed-off-by: Stefan Weil --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) +strings="${STRINGS-${cross_prefix}strings

Re: [Qemu-devel] [PATCH] configure: Use strings command from cross development tools

2018-05-14 Thread Richard Henderson
On 05/13/2018 01:50 AM, Stefan Weil wrote: > This fixes cross builds for the (rare) case where cross binutils > but no native binutils are installed. > > Signed-off-by: Stefan Weil > --- > configure | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) Reviewed-by: Richard Henderson r

Re: [Qemu-devel] [PATCH] configure: Use strings command from cross development tools

2018-05-13 Thread Philippe Mathieu-Daudé
On 05/13/2018 05:50 AM, Stefan Weil wrote: > This fixes cross builds for the (rare) case where cross binutils > but no native binutils are installed. > > Signed-off-by: Stefan Weil Reviewed-by: Philippe Mathieu-Daudé > --- > configure | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(

[Qemu-devel] [PATCH] configure: Use strings command from cross development tools

2018-05-13 Thread Stefan Weil
This fixes cross builds for the (rare) case where cross binutils but no native binutils are installed. Signed-off-by: Stefan Weil --- configure | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/configure b/configure index 24c411e346..4f6ace1ed4 100755 --- a/configure +++ b