Re: [Qemu-devel] [PATCH] configure: avoid screening of --{en, dis}able-usb-redir options

2011-11-24 Thread Peter Maydell
On 24 November 2011 09:57, Max Filippov wrote: >>> There were some --*dir that are supported by Autoconf and >>> not by QEMU configure.  The aim was to let QEMU packagers >>> use the rpm (or similar) macro that overrides directories >>> for their distribution. >> >> Ah. Can we list them explicitly

Re: [Qemu-devel] [PATCH] configure: avoid screening of --{en, dis}able-usb-redir options

2011-11-24 Thread Max Filippov
>>> In fact, what cases is this supposed to be matching? All >>> the documented --thingydir options are handled explicitly >>> earlier in the case statement. >>> >>> Paolo, you added this case in commit 6bde81cb0, but the >>> commit message doesn't give any rationale; what's it for? >> >> There wer

Re: [Qemu-devel] [PATCH] configure: avoid screening of --{en, dis}able-usb-redir options

2011-11-24 Thread Peter Maydell
On 24 November 2011 08:25, Paolo Bonzini wrote: > On 11/23/2011 11:22 PM, Peter Maydell wrote: >> In fact, what cases is this supposed to be matching? All >> the documented --thingydir options are handled explicitly >> earlier in the case statement. >> >> Paolo, you added this case in commit 6bde8

Re: [Qemu-devel] [PATCH] configure: avoid screening of --{en, dis}able-usb-redir options

2011-11-24 Thread Paolo Bonzini
On 11/23/2011 11:22 PM, Peter Maydell wrote: I just said this in the other thread, but to repeat it in the right place: I think we should expand out the case statement to explicitly list the --thingydir options it is supposed to be matching, and drop the wildcard: as this bug demonstrates it's ra

Re: [Qemu-devel] [PATCH] configure: avoid screening of --{en, dis}able-usb-redir options

2011-11-23 Thread Peter Maydell
On 23 November 2011 21:53, Max Filippov wrote: > --*dir) option pattern precede --{en,dis}able-usb-redir) patterns in the > option analysis switch, making the latter options have no effect. > > Signed-off-by: Max Filippov I just said this in the other thread, but to repeat it in the right place:

[Qemu-devel] [PATCH] configure: avoid screening of --{en, dis}able-usb-redir options

2011-11-23 Thread Max Filippov
--*dir) option pattern precede --{en,dis}able-usb-redir) patterns in the option analysis switch, making the latter options have no effect. Signed-off-by: Max Filippov --- configure |4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/configure b/configure index f033438..e5