Re: [Qemu-devel] [PATCH] configure: remove bashism (since 2010)

2015-12-10 Thread Marc-André Lureau
Hi On Thu, Dec 10, 2015 at 3:51 AM, Eric Blake wrote: > On 12/09/2015 05:53 PM, marcandre.lur...@redhat.com wrote: >> From: Marc-André Lureau >> >> "type" is not POSIX shell, but a bashism. (found thanks to shellcheck) > > NACK. 'type' is POSIX,

[Qemu-devel] [PATCH] configure: remove bashism (since 2010)

2015-12-09 Thread marcandre . lureau
From: Marc-André Lureau "type" is not POSIX shell, but a bashism. (found thanks to shellcheck) Signed-off-by: Marc-André Lureau --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure

Re: [Qemu-devel] [PATCH] configure: remove bashism (since 2010)

2015-12-09 Thread Marc-André Lureau
Hi On Thu, Dec 10, 2015 at 1:53 AM, wrote: > From: Marc-André Lureau > > "type" is not POSIX shell, but a bashism. (found thanks to shellcheck) > A subsidiary question is whether qemu really care about using POSIX shell, or we can just

Re: [Qemu-devel] [PATCH] configure: remove bashism (since 2010)

2015-12-09 Thread Eric Blake
On 12/09/2015 05:53 PM, marcandre.lur...@redhat.com wrote: > From: Marc-André Lureau > > "type" is not POSIX shell, but a bashism. (found thanks to shellcheck) NACK. 'type' is POSIX, and shellcheck is buggy.

Re: [Qemu-devel] [PATCH] configure: remove bashism (since 2010)

2015-12-09 Thread Eric Blake
On 12/09/2015 05:57 PM, Marc-André Lureau wrote: > Hi > > On Thu, Dec 10, 2015 at 1:53 AM, wrote: >> From: Marc-André Lureau >> >> "type" is not POSIX shell, but a bashism. (found thanks to shellcheck) >> > > A subsidiary question is

Re: [Qemu-devel] [PATCH] configure: remove bashism

2014-05-05 Thread Paolo Bonzini
Il 02/05/2014 13:41, Michael Tokarev ha scritto: Commit e26110cfc67d48 added a check for shacmd to create a hash for modules. This check in configure is using bash construct to redirect both stdout and stderr, whcih does fun things on some shells. Get rid of it, use standard redirection

Re: [Qemu-devel] [PATCH] configure: remove bashism

2014-05-03 Thread Fam Zheng
On Fri, 05/02 15:41, Michael Tokarev wrote: Commit e26110cfc67d48 added a check for shacmd to create a hash for modules. This check in configure is using bash construct to redirect both stdout and stderr, whcih does fun things on some s/whcih/which shells. Get rid of it, use standard

[Qemu-devel] [PATCH] configure: remove bashism

2014-05-02 Thread Michael Tokarev
Commit e26110cfc67d48 added a check for shacmd to create a hash for modules. This check in configure is using bash construct to redirect both stdout and stderr, whcih does fun things on some shells. Get rid of it, use standard redirection instead. Cc: Fam Zheng f...@redhat.com Signed-off-by: