Re: [Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState

2018-01-11 Thread Paolo Bonzini
On 11/01/2018 11:20, Peter Maydell wrote: > On 11 January 2018 at 10:15, Paolo Bonzini wrote: >> RAM contents are memcpy'd blindly during loadvm. I think that's what >> requires a tb_flush. > > Ah, that makes sense. Could we have a comment documenting the > rationale, please? Something like: >

Re: [Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState

2018-01-11 Thread Peter Maydell
On 11 January 2018 at 10:15, Paolo Bonzini wrote: > RAM contents are memcpy'd blindly during loadvm. I think that's what > requires a tb_flush. Ah, that makes sense. Could we have a comment documenting the rationale, please? Something like: /* vmload has just updated the content of RAM, bypassi

Re: [Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState

2018-01-11 Thread Paolo Bonzini
On 10/01/2018 19:32, Peter Maydell wrote: > On 10 January 2018 at 17:49, Richard Henderson > wrote: >> On 01/10/2018 05:48 AM, Pavel Dovgalyuk wrote: >>> Flushing TB cache is required because TBs key in the cache may match >>> different code which existed in the previous state. >>> >>> Signed-off-

Re: [Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState

2018-01-10 Thread Peter Maydell
On 10 January 2018 at 17:49, Richard Henderson wrote: > On 01/10/2018 05:48 AM, Pavel Dovgalyuk wrote: >> Flushing TB cache is required because TBs key in the cache may match >> different code which existed in the previous state. >> >> Signed-off-by: Pavel Dovgalyuk >> Signed-off-by: Maria Klimus

Re: [Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState

2018-01-10 Thread Dr. David Alan Gilbert
* Richard Henderson (richard.hender...@linaro.org) wrote: > On 01/10/2018 05:48 AM, Pavel Dovgalyuk wrote: > > Flushing TB cache is required because TBs key in the cache may match > > different code which existed in the previous state. > > > > Signed-off-by: Pavel Dovgalyuk > > Signed-off-by: Mar

Re: [Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState

2018-01-10 Thread Richard Henderson
On 01/10/2018 05:48 AM, Pavel Dovgalyuk wrote: > Flushing TB cache is required because TBs key in the cache may match > different code which existed in the previous state. > > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Maria Klimushenkova > --- > exec.c |1 + > 1 file changed, 1 insert

Re: [Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState

2018-01-10 Thread Paolo Bonzini
On 10/01/2018 14:48, Pavel Dovgalyuk wrote: > Flushing TB cache is required because TBs key in the cache may match > different code which existed in the previous state. > > Signed-off-by: Pavel Dovgalyuk > Signed-off-by: Maria Klimushenkova > --- > exec.c |1 + > 1 file changed, 1 insertion

[Qemu-devel] [PATCH] cpu: flush TB cache when loading VMState

2018-01-10 Thread Pavel Dovgalyuk
Flushing TB cache is required because TBs key in the cache may match different code which existed in the previous state. Signed-off-by: Pavel Dovgalyuk Signed-off-by: Maria Klimushenkova --- exec.c |1 + 1 file changed, 1 insertion(+) diff --git a/exec.c b/exec.c index 4722e52..ff31e71 100