Re: [Qemu-devel] [PATCH] e1000: Fix warning from code review

2009-11-19 Thread Ian Molton
Stefan Weil wrote: > A code review run by Steve Grubb complained about code in e1000.c: > > In hw/e1000.c at line 89, vlan is declared to be 4 bytes. > At line 382 is an attempt to do a memmove over it with a size of 12. > +/* Fields vlan and data must not be reordered or separated. */ >

[Qemu-devel] [PATCH] e1000: Fix warning from code review

2009-11-19 Thread Stefan Weil
A code review run by Steve Grubb complained about code in e1000.c: In hw/e1000.c at line 89, vlan is declared to be 4 bytes. At line 382 is an attempt to do a memmove over it with a size of 12. This was fixed by splitting the memmove in two calls and adding a comment to the declaration of vlan an