Re: [Qemu-devel] [PATCH] give some useful error messages when tap open

2010-06-22 Thread Anthony Liguori
On 06/02/2010 12:33 PM, Luiz Capitulino wrote: From: Michael Tokarev In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints (with fprintf) something like this: warning: could not open /dev/net/tun: no virtual network emulation this has 2 issues: 1) it is not a warning real

Re: [Qemu-devel] [PATCH] give some useful error messages when tap open

2010-06-03 Thread Markus Armbruster
Luiz Capitulino writes: > On Wed, 02 Jun 2010 20:26:58 +0200 > Markus Armbruster wrote: > >> Luiz Capitulino writes: >> >> > From: Michael Tokarev >> > >> > In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints >> > (with fprintf) something like this: >> > >> > warning: cou

Re: [Qemu-devel] [PATCH] give some useful error messages when tap open

2010-06-02 Thread Luiz Capitulino
On Wed, 02 Jun 2010 20:26:58 +0200 Markus Armbruster wrote: > Luiz Capitulino writes: > > > From: Michael Tokarev > > > > In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints > > (with fprintf) something like this: > > > > warning: could not open /dev/net/tun: no virtual ne

Re: [Qemu-devel] [PATCH] give some useful error messages when tap open

2010-06-02 Thread Markus Armbruster
Luiz Capitulino writes: > From: Michael Tokarev > > In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints > (with fprintf) something like this: > > warning: could not open /dev/net/tun: no virtual network emulation > > this has 2 issues: > 1) it is not a warning really, it's

[Qemu-devel] [PATCH] give some useful error messages when tap open

2010-06-02 Thread Luiz Capitulino
From: Michael Tokarev In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints (with fprintf) something like this: warning: could not open /dev/net/tun: no virtual network emulation this has 2 issues: 1) it is not a warning really, it's a fatal error (kvm exits after that), 2)

Re: [Qemu-devel] [PATCH] give some useful error messages when tap open fails

2010-04-26 Thread Anthony Liguori
On 04/23/2010 08:28 AM, Kevin Wolf wrote: Am 23.04.2010 14:52, schrieb Michael Tokarev: Kevin Wolf wrote: Am 22.04.2010 11:52, schrieb Markus Armbruster: Michael Tokarev writes: In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints (with fprintf)

Re: [Qemu-devel] [PATCH] give some useful error messages when tap open fails

2010-04-23 Thread Markus Armbruster
Michael Tokarev writes: > Markus Armbruster wrote: >> Michael Tokarev writes: >> >>> In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints >>> (with fprintf) something like this: >>> >>> warning: could not open /dev/net/tun: no virtual network emulation >>> >>> this has 2 iss

Re: [Qemu-devel] [PATCH] give some useful error messages when tap open fails

2010-04-23 Thread Kevin Wolf
Am 23.04.2010 14:52, schrieb Michael Tokarev: > Kevin Wolf wrote: >> Am 22.04.2010 11:52, schrieb Markus Armbruster: >>> Michael Tokarev writes: >>> In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints (with fprintf) something like this: > [] TFR(fd = ope

Re: [Qemu-devel] [PATCH] give some useful error messages when tap open fails

2010-04-23 Thread Michael Tokarev
Kevin Wolf wrote: > Am 22.04.2010 11:52, schrieb Markus Armbruster: >> Michael Tokarev writes: >> >>> In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints >>> (with fprintf) something like this: >>> [] >>> TFR(fd = open("/dev/net/tun", O_RDWR)); >>> if (fd < 0) { >>> -

Re: [Qemu-devel] [PATCH] give some useful error messages when tap open fails

2010-04-23 Thread Kevin Wolf
Am 22.04.2010 11:52, schrieb Markus Armbruster: > Michael Tokarev writes: > >> In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints >> (with fprintf) something like this: >> >> warning: could not open /dev/net/tun: no virtual network emulation >> >> this has 2 issues: >> 1) i

Re: [Qemu-devel] [PATCH] give some useful error messages when tap open fails

2010-04-23 Thread Michael Tokarev
Markus Armbruster wrote: > Michael Tokarev writes: > >> In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints >> (with fprintf) something like this: >> >> warning: could not open /dev/net/tun: no virtual network emulation >> >> this has 2 issues: >> 1) it is not a warning real

Re: [Qemu-devel] [PATCH] give some useful error messages when tap open fails

2010-04-22 Thread Markus Armbruster
Michael Tokarev writes: > In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints > (with fprintf) something like this: > > warning: could not open /dev/net/tun: no virtual network emulation > > this has 2 issues: > 1) it is not a warning really, it's a fatal error (kvm exits af

[Qemu-devel] [PATCH] give some useful error messages when tap open fails

2010-04-22 Thread Michael Tokarev
In net/tap-linux.c, when manipulation of /dev/net/tun fails, it prints (with fprintf) something like this: warning: could not open /dev/net/tun: no virtual network emulation this has 2 issues: 1) it is not a warning really, it's a fatal error (kvm exits after that), 2) there's no indication a