Re: [Qemu-devel] [PATCH] hw/arm/aspeed: Unlock SCU when running kernel

2017-11-13 Thread Joel Stanley
On Thu, Nov 9, 2017 at 5:54 PM, Cédric Le Goater wrote: > On 11/08/2017 04:24 AM, Joel Stanley wrote: >> --- a/hw/misc/aspeed_sdmc.c >> +++ b/hw/misc/aspeed_sdmc.c >> @@ -18,7 +18,6 @@ >> >> /* Protection Key Register */ >> #define R_PROT(0x00 / 4) >> -#define PROT_KEY_UNLOCK

Re: [Qemu-devel] [PATCH] hw/arm/aspeed: Unlock SCU when running kernel

2017-11-09 Thread Cédric Le Goater
On 11/08/2017 04:24 AM, Joel Stanley wrote: > The ASPEED hardware contains a lock register for the SCU that disables > any writes to the SCU when it is locked. The machine comes up with the > lock enabled, but on all known hardware u-boot will unlock it and leave > it unlocked when loading the kern

[Qemu-devel] [PATCH] hw/arm/aspeed: Unlock SCU when running kernel

2017-11-07 Thread Joel Stanley
The ASPEED hardware contains a lock register for the SCU that disables any writes to the SCU when it is locked. The machine comes up with the lock enabled, but on all known hardware u-boot will unlock it and leave it unlocked when loading the kernel. This means the kernel expects the SCU to be unl