Re: [Qemu-devel] [PATCH] hw/pci-host/q35: Replace hardcoded value with macro

2018-04-25 Thread no-reply
Hi, This series seems to have some coding style problems. See output below for more information: Type: series Message-id: 1524648037-5010-1-git-send-email-whois.zihan.y...@gmail.com Subject: [Qemu-devel] [PATCH] hw/pci-host/q35: Replace hardcoded value with macro === TEST SCRIPT BEGIN

[Qemu-devel] [PATCH] hw/pci-host/q35: Replace hardcoded value with macro

2018-04-25 Thread Zihan Yang
Currently part of mch_realize uses hardcoded value when initializing smram regions. Use macro to be more clear to code readers Signed-off-by: Zihan Yang --- hw/pci-host/q35.c | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git