Re: [Qemu-devel] [PATCH] pci: fix requester id with PCI bridges

2016-05-16 Thread Peter Xu
On Thu, May 12, 2016 at 10:51:43AM +0300, Michael S. Tsirkin wrote: > On Thu, May 12, 2016 at 03:32:03PM +0800, Peter Xu wrote: [...] > > > Are there cases where we need the original requester id value? > > > I am guessing not, and if I'm right we should just change the > > > implementation > > >

Re: [Qemu-devel] [PATCH] pci: fix requester id with PCI bridges

2016-05-12 Thread Michael S. Tsirkin
On Thu, May 12, 2016 at 03:32:03PM +0800, Peter Xu wrote: > On Thu, May 12, 2016 at 10:11:31AM +0300, Michael S. Tsirkin wrote: > > On Wed, May 11, 2016 at 02:53:18PM +0800, Peter Xu wrote: > > > On Wed, May 11, 2016 at 02:40:30PM +0800, Peter Xu wrote: > > > > Recently I encountered issue when deb

Re: [Qemu-devel] [PATCH] pci: fix requester id with PCI bridges

2016-05-12 Thread Peter Xu
On Thu, May 12, 2016 at 10:11:31AM +0300, Michael S. Tsirkin wrote: > On Wed, May 11, 2016 at 02:53:18PM +0800, Peter Xu wrote: > > On Wed, May 11, 2016 at 02:40:30PM +0800, Peter Xu wrote: > > > Recently I encountered issue when debugging Intel IOMMU IR codes, > > > that interrupts are not working

Re: [Qemu-devel] [PATCH] pci: fix requester id with PCI bridges

2016-05-12 Thread Michael S. Tsirkin
On Wed, May 11, 2016 at 02:53:18PM +0800, Peter Xu wrote: > On Wed, May 11, 2016 at 02:40:30PM +0800, Peter Xu wrote: > > Recently I encountered issue when debugging Intel IOMMU IR codes, > > that interrupts are not working correctly with PCI bridges (reported > > by Radim). This patch fixes the pr

Re: [Qemu-devel] [PATCH] pci: fix requester id with PCI bridges

2016-05-10 Thread Peter Xu
On Wed, May 11, 2016 at 02:40:30PM +0800, Peter Xu wrote: > Recently I encountered issue when debugging Intel IOMMU IR codes, > that interrupts are not working correctly with PCI bridges (reported > by Radim). This patch fixes the problem. I assume requester ID > should be the devfn on root PCI bus

[Qemu-devel] [PATCH] pci: fix requester id with PCI bridges

2016-05-10 Thread Peter Xu
Recently I encountered issue when debugging Intel IOMMU IR codes, that interrupts are not working correctly with PCI bridges (reported by Radim). This patch fixes the problem. I assume requester ID should be the devfn on root PCI bus (that's how I understand it before, and also in guest kernel, IRT