Paolo Bonzini writes:
> Il 20/02/2014 17:02, Andreas Färber ha scritto:
>> Not unexpected, it's the older; the - convention was introduced possibly
>> with QOM around start of 2012. Or at least there it's been enforced, and
QMP preferred '-' from the start, but insufficient decoupling from
comma
Il 20/02/2014 18:14, Roland Dreier ha scritto:
> Looks like _ is more common than - for device properties:
>
> $ git grep DEFINE_PROP_.*\(\".*_.*\" | wc -l
> 132
> $ git grep DEFINE_PROP_.*\(\".*-.*\" | wc -l
> 77
And more locally, "scsi-id" in scsi-bus.c is the only property in
hw/scsi with a '
On Thu, Feb 20, 2014 at 7:35 AM, Paolo Bonzini wrote:
> Looks like _ is more common than - for device properties:
>
> $ git grep DEFINE_PROP_.*\(\".*_.*\" | wc -l
> 132
> $ git grep DEFINE_PROP_.*\(\".*-.*\" | wc -l
> 77
And more locally, "scsi-id" in scsi-bus.c is the only property in
hw/scsi wi
Il 20/02/2014 17:02, Andreas Färber ha scritto:
Not unexpected, it's the older; the - convention was introduced possibly
with QOM around start of 2012. Or at least there it's been enforced, and
by my understanding of QOM and QMP visibility it then applies to devices
as well.
Regarding QMP, I con
Am 20.02.2014 16:35, schrieb Paolo Bonzini:
> Il 19/02/2014 23:09, Paolo Bonzini ha scritto:
>> Oversight, but it convinces me more that we should just match [_-] also
>> against the other in the pair. Must find time to write that patch...
>
> Looks like _ is more common than - for device propert
Il 19/02/2014 23:09, Paolo Bonzini ha scritto:
> Oversight, but it convinces me more that we should just match [_-] also
> against the other in the pair. Must find time to write that patch...
Looks like _ is more common than - for device properties:
$ git grep DEFINE_PROP_.*\(\".*_.*\" | wc -l
1
Il 19/02/2014 19:18, Roland Dreier ha scritto:
On Wed, Feb 19, 2014 at 10:11 AM, Andreas Färber wrote:
> HEX64 will conflict with your patches in the pending pull.
I'm not aware of the issue. Is there a better tree for me to work
against than qemu.git master?
No, I'll take care of rebasing
On Wed, Feb 19, 2014 at 10:11 AM, Andreas Färber wrote:
> HEX64 will conflict with your patches in the pending pull.
I'm not aware of the issue. Is there a better tree for me to work
against than qemu.git master?
> Also I notice that underscores are being used in new properties -
> oversight or
Am 19.02.2014 18:07, schrieb Paolo Bonzini:
> Il 19/02/2014 17:28, Roland Dreier ha scritto:
>> From: Roland Dreier
>>
>> To make a VM more convincing to my application, it's useful to be able
>> to add a port WWN and relative target port index to the descriptors
>> returned for VPD page 83h. Add
Il 19/02/2014 17:28, Roland Dreier ha scritto:
From: Roland Dreier
To make a VM more convincing to my application, it's useful to be able
to add a port WWN and relative target port index to the descriptors
returned for VPD page 83h. Add device properties to allow setting
these, and return them
From: Roland Dreier
To make a VM more convincing to my application, it's useful to be able
to add a port WWN and relative target port index to the descriptors
returned for VPD page 83h. Add device properties to allow setting
these, and return them from INQUIRY commands.
Signed-off-by: Roland Dr
11 matches
Mail list logo
