Hello!
> Please don't do two things in one patch. (I actually read this patch
> code-first and thought you'd accidentally inserted this change due
> to a rebasing mishap...) It's particularly bad in patches which are
> otherwise almost entirely moving code from one file to another,
> because it's
On 23 October 2015 at 16:01, Pavel Fedin wrote:
> Hello!
>
>> Please don't do two things in one patch. (I actually read this patch
>> code-first and thought you'd accidentally inserted this change due
>> to a rebasing mishap...) It's particularly bad in patches which are
>> otherwise almost entir
On 22 October 2015 at 14:09, Pavel Fedin wrote:
> Includes, which reside in target-arm, are very problematic to use from code
> which is considered target-independent by the build system (for example,
> hw/intc/something.c). It happens because they depend on config-target.h,
> which is unreachable
Includes, which reside in target-arm, are very problematic to use from code
which is considered target-independent by the build system (for example,
hw/intc/something.c). It happens because they depend on config-target.h,
which is unreachable in this case. This creates problems for example for
GICv
