Re: [Qemu-devel] [PATCH] target-mips: Clean up microMIPS32 major opcode

2012-11-15 Thread Johnson, Eric
> -Original Message- > From: 陳韋任 (Wei-Ren Chen) [mailto:che...@iis.sinica.edu.tw] > Sent: Wednesday, November 14, 2012 9:51 PM > To: Johnson, Eric > Cc: qemu-devel@nongnu.org; qemu-triv...@nongnu.org; Jia Liu; Aurelien > Jarno > Subject: Re: [Qemu-devel] [PATCH]

Re: [Qemu-devel] [PATCH] target-mips: Clean up microMIPS32 major opcode

2012-11-15 Thread Johnson, Eric
devel] [PATCH] target-mips: Clean up microMIPS32 major > opcode > > On Thu, Nov 15, 2012 at 02:34:31AM +, Johnson, Eric wrote: > > Hi Chen, > > > > Please only remove the POOL48A opcode. > > > > The others are documented in the microMIPS64 Instruction

Re: [Qemu-devel] [PATCH] target-mips: Clean up microMIPS32 major opcode

2012-11-15 Thread Aurelien Jarno
On Thu, Nov 15, 2012 at 02:34:31AM +, Johnson, Eric wrote: > Hi Chen, > > Please only remove the POOL48A opcode. > > The others are documented in the microMIPS64 Instruction Set manual ( > http://www.mips.com/secure-download/index.dot?product_name=/auth/MD00087-2B-MIPS64BIS-AFP-03.51.pdf >

Re: [Qemu-devel] [PATCH] target-mips: Clean up microMIPS32 major opcode

2012-11-14 Thread Wei-Ren Chen
On Thu, Nov 15, 2012 at 04:01:32AM +, Johnson, Eric wrote: > Hi Chen, > > Sorry I must have made a copy paste error. I access the documents > internally. I'll double check the link tomorrow. > > The document I referenced is the MIPS64 not the microMIPS64. > > Do not change the names. The L

Re: [Qemu-devel] [PATCH] target-mips: Clean up microMIPS32 major opcode

2012-11-14 Thread Johnson, Eric
Hi Chen, Sorry I must have made a copy paste error. I access the documents internally. I'll double check the link tomorrow. The document I referenced is the MIPS64 not the microMIPS64. Do not change the names. The LD32 and SD32 are microMIPS specific. The assembler LD and SD opcodes work for

Re: [Qemu-devel] [PATCH] target-mips: Clean up microMIPS32 major opcode

2012-11-14 Thread Wei-Ren Chen
On Thu, Nov 15, 2012 at 02:34:31AM +, Johnson, Eric wrote: > Hi Chen, > > Please only remove the POOL48A opcode. > > The others are documented in the microMIPS64 Instruction Set manual ( > http://www.mips.com/secure-download/index.dot?product_name=/auth/MD00087-2B-MIPS64BIS-AFP-03.51.pdf >

Re: [Qemu-devel] [PATCH] target-mips: Clean up microMIPS32 major opcode

2012-11-14 Thread Johnson, Eric
??? (Wei-Ren Chen) > Sent: Wednesday, November 14, 2012 6:15 PM > To: qemu-devel@nongnu.org; qemu-triv...@nongnu.org > Cc: che...@cs.nctu.edu.tw; Jia Liu; Aurelien Jarno > Subject: [Qemu-devel] [PATCH] target-mips: Clean up microMIPS32 major > opcode > > Hi all, > > I

[Qemu-devel] [PATCH] target-mips: Clean up microMIPS32 major opcode

2012-11-14 Thread Wei-Ren Chen
Hi all, I check MIPS microMIPS manual [1], and found the major opcode might be wrong. I add a comment to explicitly indicate what manual I am refering to, and according that manual I remove some microMIPS32 major opcodes. Major opcode 0x1f is reserved, so I just remove it. As for others, like 0x