Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-22 Thread Richard Henderson
On 09/21/2017 04:59 AM, Thomas Huth wrote: > $ time ppc64-softmmu/qemu-system-ppc64 -nographic -vga none -prom-env > 'use-nvramrc?=true' -prom-env 'nvramrc=power-off' > [...] > real 0m13.953s > user 0m13.904s > sys 0m0.046s > > That's impressive! Richard, may I ask what's the current state of

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-21 Thread Thomas Huth
On 12.09.2017 17:13, Paolo Bonzini wrote: > On 12/09/2017 16:56, Thomas Huth wrote: >> The problem is that the SLOF firmware just performs very badly with TCG >> (it's fine on real hardware). It executes a lot of Forth code, and the >> Forth interpreter uses things like computed gotos or other tric

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-12 Thread Paolo Bonzini
On 12/09/2017 16:56, Thomas Huth wrote: > The problem is that the SLOF firmware just performs very badly with TCG > (it's fine on real hardware). It executes a lot of Forth code, and the > Forth interpreter uses things like computed gotos or other tricks that > basically prevent proper JIT operatio

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-12 Thread Thomas Huth
On 12.09.2017 11:20, Stefan Weil wrote: > Am 12.09.2017 um 10:52 schrieb Stefan Weil: >> Am 11.09.2017 um 20:24 schrieb Peter Maydell: >>> I've also turned on a tci compile check on my pre-merge tests. >>> (It doesn't pass "make check" for me, though...) thanks -- PMM >> >> "make check-qtest-ppc64"

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-12 Thread Stefan Weil
Am 12.09.2017 um 10:52 schrieb Stefan Weil: > Am 11.09.2017 um 20:24 schrieb Peter Maydell: >> I've also turned on a tci compile check on my pre-merge tests. >> (It doesn't pass "make check" for me, though...) thanks -- PMM > > "make check-qtest-ppc64" fails for me, too. > > Thomas, this seems to

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-12 Thread Stefan Weil
Am 11.09.2017 um 20:24 schrieb Peter Maydell: > I've also turned on a tci compile check on my pre-merge tests. > (It doesn't pass "make check" for me, though...) thanks -- PMM "make check-qtest-ppc64" fails for me, too. Thomas, this seems to be again the well known timing problem in tests/prom-en

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-11 Thread Philippe Mathieu-Daudé
Hi Stefan, On 09/11/2017 05:26 PM, Stefan Weil wrote:> I had an assertion because of a missing qemu-ga when I‌ only had run "make check", so there is a dependency (perhaps check: tools) missing. Now "make check" is running fine with all targets (at least until check-qtest-ppc64). Sorry, I have

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-11 Thread Stefan Weil
Am 11.09.2017 um 20:24 schrieb Peter Maydell: > I've also turned on a tci compile check on my pre-merge tests. > (It doesn't pass "make check" for me, though...) Did you run "make" before running "make check"? I had an assertion because of a missing qemu-ga when I‌ only had run "make check", so t

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-11 Thread Stefan Weil
Am 11.09.2017 um 21:47 schrieb Philippe Mathieu-Daudé: [...]> Stefan are you testing no-X86 targets? I only tested x86_64: ./configure --enable-debug --enable-tcg-interpreter \ --target-list=x86_64-linux-user,x86_64-softmmu If other targets fail, I'll have a look to find the cause. Stefan

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-11 Thread Philippe Mathieu-Daudé
Hi Peter, Stefan, Am 11.09.2017 um 20:24 schrieb Peter Maydell: I've also turned on a tci compile check on my pre-merge tests. (It doesn't pass "make check" for me, though...) Peter you might want to restrict it to X86... --target-list=subdir-i386-softmmu,x86_64-softmmu,x86_64-linux-user

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-11 Thread Stefan Weil
Am 11.09.2017 um 20:24 schrieb Peter Maydell: > On 11 September 2017 at 19:01, Richard Henderson > wrote: >> On 09/10/2017 07:28 PM, Philippe Mathieu-Daudé wrote: >>> changed in 659ef5cbb893, this fixes building with --enable-tcg-interpreter: >>> >>> /home/travis/build/qemu/qemu/tcg/tcg.c:116:14:

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-11 Thread Peter Maydell
On 11 September 2017 at 19:01, Richard Henderson wrote: > On 09/10/2017 07:28 PM, Philippe Mathieu-Daudé wrote: >> changed in 659ef5cbb893, this fixes building with --enable-tcg-interpreter: >> >> /home/travis/build/qemu/qemu/tcg/tcg.c:116:14: error: >> ‘tcg_out_ldst_finalize’ used but never defi

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-11 Thread Peter Maydell
On 11 September 2017 at 19:13, Philippe Mathieu-Daudé wrote: > On 09/10/2017 11:28 PM, Philippe Mathieu-Daudé wrote: >> >> changed in 659ef5cbb893, this fixes building with >> --enable-tcg-interpreter: >> >> /home/travis/build/qemu/qemu/tcg/tcg.c:116:14: error: >> ‘tcg_out_ldst_finalize’ used but

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-11 Thread Philippe Mathieu-Daudé
On 09/10/2017 11:28 PM, Philippe Mathieu-Daudé wrote: changed in 659ef5cbb893, this fixes building with --enable-tcg-interpreter: /home/travis/build/qemu/qemu/tcg/tcg.c:116:14: error: ‘tcg_out_ldst_finalize’ used but never defined [-Werror] static bool tcg_out_ldst_finalize(TCGContext *s);

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-11 Thread Richard Henderson
On 09/10/2017 07:28 PM, Philippe Mathieu-Daudé wrote: > changed in 659ef5cbb893, this fixes building with --enable-tcg-interpreter: > > /home/travis/build/qemu/qemu/tcg/tcg.c:116:14: error: ‘tcg_out_ldst_finalize’ > used but never defined [-Werror] > static bool tcg_out_ldst_finalize(TCGContext

Re: [Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-10 Thread Stefan Weil
Am 11.09.2017 um 04:28 schrieb Philippe Mathieu-Daudé: > changed in 659ef5cbb893, this fixes building with --enable-tcg-interpreter: > > /home/travis/build/qemu/qemu/tcg/tcg.c:116:14: error: ‘tcg_out_ldst_finalize’ > used but never defined [-Werror] > static bool tcg_out_ldst_finalize(TCGContext

[Qemu-devel] [PATCH] tcg/tci: do not use ldst label (never implemented)

2017-09-10 Thread Philippe Mathieu-Daudé
changed in 659ef5cbb893, this fixes building with --enable-tcg-interpreter: /home/travis/build/qemu/qemu/tcg/tcg.c:116:14: error: ‘tcg_out_ldst_finalize’ used but never defined [-Werror] static bool tcg_out_ldst_finalize(TCGContext *s); ^ Signed-off-by: Philippe Mathieu-Daudé ---