Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

2016-12-07 Thread Greg Kurz
On Tue, 6 Dec 2016 20:30:52 + Stefan Hajnoczi wrote: > On Tue, Dec 06, 2016 at 05:48:00PM -0200, Eduardo Habkost wrote: > > On Tue, Dec 06, 2016 at 09:44:11PM +0200, Michael S. Tsirkin wrote: > > > On Tue, Dec 06, 2016 at 05:40:29PM -0200, Eduardo Habkost wrote: > > > > On Tue, Dec 06, 20

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

2016-12-06 Thread Stefan Hajnoczi
On Tue, Dec 06, 2016 at 05:48:00PM -0200, Eduardo Habkost wrote: > On Tue, Dec 06, 2016 at 09:44:11PM +0200, Michael S. Tsirkin wrote: > > On Tue, Dec 06, 2016 at 05:40:29PM -0200, Eduardo Habkost wrote: > > > On Tue, Dec 06, 2016 at 09:36:07PM +0200, Michael S. Tsirkin wrote: > > > > On Tue, Dec 0

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

2016-12-06 Thread Michael S. Tsirkin
On Tue, Dec 06, 2016 at 05:40:29PM -0200, Eduardo Habkost wrote: > On Tue, Dec 06, 2016 at 09:36:07PM +0200, Michael S. Tsirkin wrote: > > On Tue, Dec 06, 2016 at 05:33:49PM -0200, Eduardo Habkost wrote: > > > On Tue, Dec 06, 2016 at 09:31:43PM +0200, Michael S. Tsirkin wrote: > > > > On Tue, Dec 0

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

2016-12-06 Thread Eduardo Habkost
On Tue, Dec 06, 2016 at 09:44:11PM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 06, 2016 at 05:40:29PM -0200, Eduardo Habkost wrote: > > On Tue, Dec 06, 2016 at 09:36:07PM +0200, Michael S. Tsirkin wrote: > > > On Tue, Dec 06, 2016 at 05:33:49PM -0200, Eduardo Habkost wrote: > > > > On Tue, Dec 0

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

2016-12-06 Thread Eduardo Habkost
On Tue, Dec 06, 2016 at 09:36:07PM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 06, 2016 at 05:33:49PM -0200, Eduardo Habkost wrote: > > On Tue, Dec 06, 2016 at 09:31:43PM +0200, Michael S. Tsirkin wrote: > > > On Tue, Dec 06, 2016 at 06:50:47PM +0100, Greg Kurz wrote: > > > > Since commit "9a4c0

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

2016-12-06 Thread Michael S. Tsirkin
On Tue, Dec 06, 2016 at 05:33:49PM -0200, Eduardo Habkost wrote: > On Tue, Dec 06, 2016 at 09:31:43PM +0200, Michael S. Tsirkin wrote: > > On Tue, Dec 06, 2016 at 06:50:47PM +0100, Greg Kurz wrote: > > > Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio behaviour", passing > > > -device virtio-b

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

2016-12-06 Thread Eduardo Habkost
On Tue, Dec 06, 2016 at 09:31:43PM +0200, Michael S. Tsirkin wrote: > On Tue, Dec 06, 2016 at 06:50:47PM +0100, Greg Kurz wrote: > > Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio behaviour", passing > > -device virtio-blk-pci.disable-modern=off has no effect on 2.6 machine > > types because

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

2016-12-06 Thread Michael S. Tsirkin
On Tue, Dec 06, 2016 at 06:50:47PM +0100, Greg Kurz wrote: > Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio behaviour", passing > -device virtio-blk-pci.disable-modern=off has no effect on 2.6 machine > types because the internal virtio-pci.disable-modern=on compat property > always prevail.

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

2016-12-06 Thread Eduardo Habkost
On Tue, Dec 06, 2016 at 06:50:47PM +0100, Greg Kurz wrote: > Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio behaviour", passing > -device virtio-blk-pci.disable-modern=off has no effect on 2.6 machine > types because the internal virtio-pci.disable-modern=on compat property > always prevail.

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

2016-12-06 Thread Eduardo Habkost
On Tue, Dec 06, 2016 at 06:50:47PM +0100, Greg Kurz wrote: > Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio behaviour", passing > -device virtio-blk-pci.disable-modern=off has no effect on 2.6 machine > types because the internal virtio-pci.disable-modern=on compat property > always prevail.

Re: [Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

2016-12-06 Thread Cornelia Huck
On Tue, 06 Dec 2016 18:50:47 +0100 Greg Kurz wrote: > Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio behaviour", passing > -device virtio-blk-pci.disable-modern=off has no effect on 2.6 machine > types because the internal virtio-pci.disable-modern=on compat property > always prevail. s/pr

[Qemu-devel] [PATCH] virtio: fix HW_COMPAT_2_6 macro for virtio-*-pci drivers

2016-12-06 Thread Greg Kurz
Since commit "9a4c0e220d8a hw/virtio-pci: fix virtio behaviour", passing -device virtio-blk-pci.disable-modern=off has no effect on 2.6 machine types because the internal virtio-pci.disable-modern=on compat property always prevail. This should ideally be fixed in the qdev properties core code, but