Re: [Qemu-devel] [PATCH] vmware_vga: Cleanup and allow simple drivers to work without the fifo

2012-08-24 Thread Stefan Hajnoczi
On Wed, Aug 22, 2012 at 05:23:49PM +0200, Jan Kiszka wrote: On 2012-08-22 12:19, BALATON Zoltan wrote: On Wed, 22 Aug 2012, Jan Kiszka wrote: This is a rather big patch. I strongly suspect you can break it up into smaller pieces that address separate aspects one-by-one. Also, it is

Re: [Qemu-devel] [PATCH] vmware_vga: Cleanup and allow simple drivers to work without the fifo

2012-08-22 Thread Jan Kiszka
On 2012-08-21 23:33, BALATON Zoltan wrote: Detailed changes: Removing info available elsewhere from vmsvga_state. Fix mixup between depth and bits per pixel. Return a value for FB_SIZE even before enabled (according to the documentation, drivers should read this value before enabling the

Re: [Qemu-devel] [PATCH] vmware_vga: Cleanup and allow simple drivers to work without the fifo

2012-08-22 Thread BALATON Zoltan
On Wed, 22 Aug 2012, Jan Kiszka wrote: This is a rather big patch. I strongly suspect you can break it up into smaller pieces that address separate aspects one-by-one. Also, it is definitely to heavy for qemu-trivial. Despite its size the changes included are fairly simple but I can try to

Re: [Qemu-devel] [PATCH] vmware_vga: Cleanup and allow simple drivers to work without the fifo

2012-08-22 Thread Jan Kiszka
On 2012-08-22 12:19, BALATON Zoltan wrote: On Wed, 22 Aug 2012, Jan Kiszka wrote: This is a rather big patch. I strongly suspect you can break it up into smaller pieces that address separate aspects one-by-one. Also, it is definitely to heavy for qemu-trivial. Despite its size the changes

[Qemu-devel] [PATCH] vmware_vga: Cleanup and allow simple drivers to work without the fifo

2012-08-21 Thread BALATON Zoltan
Detailed changes: Removing info available elsewhere from vmsvga_state. Fix mixup between depth and bits per pixel. Return a value for FB_SIZE even before enabled (according to the documentation, drivers should read this value before enabling the device). Postpone stopping the dirty log to the