Re: [Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block

2018-12-14 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 14 Dec 2018 at 12:31, Markus Armbruster wrote: >> Peter Maydell writes: >> > On Fri, 14 Dec 2018 at 06:29, Markus Armbruster wrote: >> > I have to admit I never really understood what tweak >> > you wanted making to the commit message. I'm happy >> > to make it

Re: [Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block

2018-12-14 Thread Peter Maydell
On Fri, 14 Dec 2018 at 12:31, Markus Armbruster wrote: > Peter Maydell writes: > > On Fri, 14 Dec 2018 at 06:29, Markus Armbruster wrote: > > I have to admit I never really understood what tweak > > you wanted making to the commit message. I'm happy > > to make it clearer: do you want to

Re: [Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block

2018-12-14 Thread Markus Armbruster
Peter Maydell writes: > On Fri, 14 Dec 2018 at 06:29, Markus Armbruster wrote: >> >> Paolo Bonzini writes: >> >> > On 13/12/18 19:21, Peter Maydell wrote: >> >> On Thu, 13 Dec 2018 at 18:07, Paolo Bonzini wrote: >> >>> On 13/12/18 19:01, Peter Maydell wrote: >> I sent a patch to do this

Re: [Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block

2018-12-14 Thread Wainer dos Santos Moschetta
On 12/13/2018 04:01 PM, Peter Maydell wrote: On Thu, 13 Dec 2018 at 17:57, Wainer dos Santos Moschetta wrote: Eduardo Habkost pointed out a malformed block of comments on my patch [1] that I had ran checkpatch.pl and no warn/error was reported. Then I realized the script does not catch such

Re: [Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block

2018-12-14 Thread Peter Maydell
On Fri, 14 Dec 2018 at 06:29, Markus Armbruster wrote: > > Paolo Bonzini writes: > > > On 13/12/18 19:21, Peter Maydell wrote: > >> On Thu, 13 Dec 2018 at 18:07, Paolo Bonzini wrote: > >>> On 13/12/18 19:01, Peter Maydell wrote: > I sent a patch to do this a little while back: >

Re: [Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block

2018-12-14 Thread Paolo Bonzini
On 14/12/18 07:29, Markus Armbruster wrote: > Paolo Bonzini writes: > >> On 13/12/18 19:21, Peter Maydell wrote: >>> On Thu, 13 Dec 2018 at 18:07, Paolo Bonzini wrote: On 13/12/18 19:01, Peter Maydell wrote: > I sent a patch to do this a little while back: >

Re: [Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block

2018-12-13 Thread Markus Armbruster
Paolo Bonzini writes: > On 13/12/18 19:21, Peter Maydell wrote: >> On Thu, 13 Dec 2018 at 18:07, Paolo Bonzini wrote: >>> On 13/12/18 19:01, Peter Maydell wrote: I sent a patch to do this a little while back: https://patchwork.kernel.org/patch/10561557/ It didn't get

Re: [Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block

2018-12-13 Thread Paolo Bonzini
On 13/12/18 19:21, Peter Maydell wrote: > On Thu, 13 Dec 2018 at 18:07, Paolo Bonzini wrote: >> On 13/12/18 19:01, Peter Maydell wrote: >>> I sent a patch to do this a little while back: >>> https://patchwork.kernel.org/patch/10561557/ >>> >>> It didn't get applied because Paolo disagreed with

Re: [Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block

2018-12-13 Thread Peter Maydell
On Thu, 13 Dec 2018 at 18:07, Paolo Bonzini wrote: > On 13/12/18 19:01, Peter Maydell wrote: > > I sent a patch to do this a little while back: > > https://patchwork.kernel.org/patch/10561557/ > > > > It didn't get applied because Paolo disagreed with having > > our tools enforcing what our

Re: [Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block

2018-12-13 Thread Paolo Bonzini
On 13/12/18 19:01, Peter Maydell wrote: > On Thu, 13 Dec 2018 at 17:57, Wainer dos Santos Moschetta > wrote: >> >> Eduardo Habkost pointed out a malformed block of comments on my >> patch [1] that I had ran checkpatch.pl and no warn/error was >> reported. Then I realized the script does not catch

Re: [Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block

2018-12-13 Thread Peter Maydell
On Thu, 13 Dec 2018 at 17:57, Wainer dos Santos Moschetta wrote: > > Eduardo Habkost pointed out a malformed block of comments on my > patch [1] that I had ran checkpatch.pl and no warn/error was > reported. Then I realized the script does not catch such as > case (or it had a bug). > > It turns

[Qemu-devel] [PATCH 0/1] checkpatch: checker for comment block

2018-12-13 Thread Wainer dos Santos Moschetta
Eduardo Habkost pointed out a malformed block of comments on my patch [1] that I had ran checkpatch.pl and no warn/error was reported. Then I realized the script does not catch such as case (or it had a bug). It turns out that checkpatch.pl does not parse comment blocks (If I understood its code