Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-11-11 Thread Alon Levy
On Thu, Nov 11, 2010 at 04:03:14PM +0100, Markus Armbruster wrote: [snip] > Agree. > > Summary so far: > > 1. usb_{attach,detach} looks like yet another special-purpose command >where a general command would make sense, namely >device_{attach,detach}. We have a few of those, e.g. usb_add

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-11-11 Thread Markus Armbruster
Alon Levy writes: > On Thu, Nov 11, 2010 at 11:29:36AM +0100, Markus Armbruster wrote: >> Alon Levy writes: >> >> > On Wed, Nov 10, 2010 at 04:49:38PM +0100, Markus Armbruster wrote: >> >> Sorry for coming so late to this thread... >> >> >> >> Alon Levy writes: >> >> >> >> > On Thu, Oct 21,

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-11-11 Thread Alon Levy
On Thu, Nov 11, 2010 at 11:29:36AM +0100, Markus Armbruster wrote: > Alon Levy writes: > > > On Wed, Nov 10, 2010 at 04:49:38PM +0100, Markus Armbruster wrote: > >> Sorry for coming so late to this thread... > >> > >> Alon Levy writes: > >> > >> > On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anth

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-11-11 Thread Markus Armbruster
Alon Levy writes: > On Wed, Nov 10, 2010 at 04:49:38PM +0100, Markus Armbruster wrote: >> Sorry for coming so late to this thread... >> >> Alon Levy writes: >> >> > On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: >> >> On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: >> >> >On 10/

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-11-10 Thread Alon Levy
On Wed, Nov 10, 2010 at 04:49:38PM +0100, Markus Armbruster wrote: > Sorry for coming so late to this thread... > > Alon Levy writes: > > > On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: > >> On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: > >> >On 10/21/10 08:36, Alon Levy wrote:

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-11-10 Thread Markus Armbruster
Sorry for coming so late to this thread... Alon Levy writes: > On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: >> On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: >> >On 10/21/10 08:36, Alon Levy wrote: >> >>v2->v3 changes: >> >> * add configure parameter >> >> * fix docs >> >> >>

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-25 Thread Alon Levy
On Fri, Oct 22, 2010 at 07:55:02AM -0500, Anthony Liguori wrote: > On 10/22/2010 07:48 AM, Luiz Capitulino wrote: > >On Thu, 21 Oct 2010 15:27:23 +0200 > >Alon Levy wrote: > > > >>On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: > >>>On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: > >

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-22 Thread Luiz Capitulino
On Fri, 22 Oct 2010 08:43:39 -0500 Anthony Liguori wrote: > On 10/22/2010 08:17 AM, Luiz Capitulino wrote: > > You and Gerd asked about the purpose of this command, turns out that it's > > only useful for developing new USB devices for QEMU, so I thought it would > > be better to restrict it, so

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-22 Thread Anthony Liguori
On 10/22/2010 08:17 AM, Luiz Capitulino wrote: You and Gerd asked about the purpose of this command, turns out that it's only useful for developing new USB devices for QEMU, so I thought it would be better to restrict it, so that people don't start using this the wrong way or worse, we can't drop

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-22 Thread Anthony Liguori
On 10/22/2010 07:48 AM, Luiz Capitulino wrote: On Thu, 21 Oct 2010 15:27:23 +0200 Alon Levy wrote: On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: On 10/21/10 08:36, Alon Levy wrote: v2->v3 changes:

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-22 Thread Luiz Capitulino
On Fri, 22 Oct 2010 07:55:02 -0500 Anthony Liguori wrote: > On 10/22/2010 07:48 AM, Luiz Capitulino wrote: > > On Thu, 21 Oct 2010 15:27:23 +0200 > > Alon Levy wrote: > > > > > >> On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: > >> > >>> On 10/21/2010 08:03 AM, Gerd H

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-22 Thread Luiz Capitulino
On Thu, 21 Oct 2010 15:27:23 +0200 Alon Levy wrote: > On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: > > On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: > > >On 10/21/10 08:36, Alon Levy wrote: > > >>v2->v3 changes: > > >> * add configure parameter > > >> * fix docs > > >> > > >>

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-21 Thread Ryan Harper
* Alon Levy [2010-10-21 08:26]: > On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: > > On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: > > >On 10/21/10 08:36, Alon Levy wrote: > > >>v2->v3 changes: > > >> * add configure parameter > > >> * fix docs > > >> > > >>v2 message: > > >>Thi

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-21 Thread Alon Levy
On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: > On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: > >On 10/21/10 08:36, Alon Levy wrote: > >>v2->v3 changes: > >> * add configure parameter > >> * fix docs > >> > >>v2 message: > >>This patchset uses id like device_del for attaching/de

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-21 Thread Alon Levy
On Thu, Oct 21, 2010 at 08:13:19AM -0500, Anthony Liguori wrote: > On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: > >On 10/21/10 08:36, Alon Levy wrote: > >>v2->v3 changes: > >> * add configure parameter > >> * fix docs > >> > >>v2 message: > >>This patchset uses id like device_del for attaching/de

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-21 Thread Anthony Liguori
On 10/21/2010 08:03 AM, Gerd Hoffmann wrote: On 10/21/10 08:36, Alon Levy wrote: v2->v3 changes: * add configure parameter * fix docs v2 message: This patchset uses id like device_del for attaching/detaching usb devices. The first two patches ready the way: 1. makes qdev_find_recursive no

Re: [Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-21 Thread Gerd Hoffmann
On 10/21/10 08:36, Alon Levy wrote: v2->v3 changes: * add configure parameter * fix docs v2 message: This patchset uses id like device_del for attaching/detaching usb devices. The first two patches ready the way: 1. makes qdev_find_recursive non static and in qdev.h 2. adds a usb_device_

[Qemu-devel] [PATCH 0/3] add usb_detach and usb_attach (v3)

2010-10-20 Thread Alon Levy
v2->v3 changes: * add configure parameter * fix docs v2 message: This patchset uses id like device_del for attaching/detaching usb devices. The first two patches ready the way: 1. makes qdev_find_recursive non static and in qdev.h 2. adds a usb_device_by_id which goes over the usb buses callin