Re: [Qemu-devel] [PATCH 0/4] migration: Improve subsections detection

2011-10-04 Thread Avi Kivity
On 10/04/2011 08:35 PM, Juan Quintela wrote: Avi Kivity wrote: > On 10/04/2011 04:38 PM, Juan Quintela wrote: >> Hi >> >> This series move the subsections detection code form: >> - Look that it starts form 5 >> To: >> - Look that it starts form 5 (SUBSECTION) >> - Look at the length >> -

Re: [Qemu-devel] [PATCH 0/4] migration: Improve subsections detection

2011-10-04 Thread Juan Quintela
Avi Kivity wrote: > On 10/04/2011 04:38 PM, Juan Quintela wrote: >> Hi >> >> This series move the subsections detection code form: >> - Look that it starts form 5 >> To: >> - Look that it starts form 5 (SUBSECTION) >> - Look at the length >> - Look that length is bigger than section name >> - Look

Re: [Qemu-devel] [PATCH 0/4] migration: Improve subsections detection

2011-10-04 Thread Avi Kivity
On 10/04/2011 08:22 PM, Anthony Liguori wrote: The original intent with subsections was to register them as a new vmstate section, with just a name relationship. Can we rename .subsections to .old_and_semi_broken_subsections, and introduce a new .subsections field that works properly in all c

Re: [Qemu-devel] [PATCH 0/4] migration: Improve subsections detection

2011-10-04 Thread Anthony Liguori
On 10/04/2011 01:20 PM, Avi Kivity wrote: On 10/04/2011 04:38 PM, Juan Quintela wrote: Hi This series move the subsections detection code form: - Look that it starts form 5 To: - Look that it starts form 5 (SUBSECTION) - Look at the length - Look that length is bigger than section name - Look a

Re: [Qemu-devel] [PATCH 0/4] migration: Improve subsections detection

2011-10-04 Thread Avi Kivity
On 10/04/2011 04:38 PM, Juan Quintela wrote: Hi This series move the subsections detection code form: - Look that it starts form 5 To: - Look that it starts form 5 (SUBSECTION) - Look at the length - Look that length is bigger than section name - Look at the idstr and see that it starts with the

Re: [Qemu-devel] [PATCH 0/4] migration: Improve subsections detection

2011-10-04 Thread Paolo Bonzini
On 10/04/2011 04:38 PM, Juan Quintela wrote: Hi This series move the subsections detection code form: - Look that it starts form 5 To: - Look that it starts form 5 (SUBSECTION) - Look at the length - Look that length is bigger than section name - Look at the idstr and see that it starts with the

[Qemu-devel] [PATCH 0/4] migration: Improve subsections detection

2011-10-04 Thread Juan Quintela
Hi This series move the subsections detection code form: - Look that it starts form 5 To: - Look that it starts form 5 (SUBSECTION) - Look at the length - Look that length is bigger than section name - Look at the idstr and see that it starts with the subsection name. Please review. Later, Juan.