Re: [Qemu-devel] [PATCH 01/12] nbd: rename read_sync and friends

2017-06-02 Thread Eric Blake
On 06/02/2017 08:54 AM, Vladimir Sementsov-Ogievskiy wrote: >>> Finally, are you OK with my wording? If I reroll, can I add your r-b? >> What final wording are you proposing (full paragraph, not a snippet)? > > 2. _sync suffix >_sync is related to the fact that nbd_wr_syncv doesn't return if

Re: [Qemu-devel] [PATCH 01/12] nbd: rename read_sync and friends

2017-06-02 Thread Vladimir Sementsov-Ogievskiy
02.06.2017 17:15, Eric Blake wrote: On 06/02/2017 08:54 AM, Vladimir Sementsov-Ogievskiy wrote: Finally, are you OK with my wording? If I reroll, can I add your r-b? What final wording are you proposing (full paragraph, not a snippet)? 2. _sync suffix _sync is related to the fact that

Re: [Qemu-devel] [PATCH 01/12] nbd: rename read_sync and friends

2017-06-02 Thread Vladimir Sementsov-Ogievskiy
02.06.2017 16:49, Eric Blake wrote: On 06/02/2017 07:00 AM, Vladimir Sementsov-Ogievskiy wrote: 2. _sync suffix _sync is related to the fact, that nbd_wr_syncv doesn't return if s/fact,/fact/ write to socket returns EAGAIN. In first implementation nbd_wr_syncv just loops

Re: [Qemu-devel] [PATCH 01/12] nbd: rename read_sync and friends

2017-06-02 Thread Eric Blake
On 06/02/2017 07:00 AM, Vladimir Sementsov-Ogievskiy wrote: 2. _sync suffix _sync is related to the fact, that nbd_wr_syncv doesn't return if >>> s/fact,/fact/ >>> write to socket returns EAGAIN. In first implementation nbd_wr_syncv just loops while getting

Re: [Qemu-devel] [PATCH 01/12] nbd: rename read_sync and friends

2017-06-02 Thread Vladimir Sementsov-Ogievskiy
01.06.2017 11:03, Sementsov-Ogievskiy Vladimir wrote: On 31.05.2017 21:46, Eric Blake wrote: On 05/31/2017 11:55 AM, Vladimir Sementsov-Ogievskiy wrote: Rename nbd_wr_syncv -> nbd_rwv read_sync -> nbd_read read_sync_eof -> nbd_read_eof write_sync -> nbd_write drop_sync ->

Re: [Qemu-devel] [PATCH 01/12] nbd: rename read_sync and friends

2017-06-01 Thread Sementsov-Ogievskiy Vladimir
On 31.05.2017 21:46, Eric Blake wrote: On 05/31/2017 11:55 AM, Vladimir Sementsov-Ogievskiy wrote: Rename nbd_wr_syncv -> nbd_rwv read_sync -> nbd_read read_sync_eof -> nbd_read_eof write_sync -> nbd_write drop_sync -> nbd_drop 1. nbd_ prefix read_sync and write_sync are

Re: [Qemu-devel] [PATCH 01/12] nbd: rename read_sync and friends

2017-05-31 Thread Eric Blake
On 05/31/2017 11:55 AM, Vladimir Sementsov-Ogievskiy wrote: > Rename > nbd_wr_syncv -> nbd_rwv > read_sync -> nbd_read > read_sync_eof -> nbd_read_eof > write_sync -> nbd_write > drop_sync -> nbd_drop > > 1. nbd_ prefix >read_sync and write_sync are already shared, so it is good to

Re: [Qemu-devel] [PATCH 01/12] nbd: rename read_sync and friends

2017-05-31 Thread Vladimir Sementsov-Ogievskiy
31.05.2017 19:55, Vladimir Sementsov-Ogievskiy wrote: Rename nbd_wr_syncv -> nbd_rwv read_sync -> nbd_read read_sync_eof -> nbd_read_eof write_sync -> nbd_write drop_sync -> nbd_drop 1. nbd_ prefix read_sync and write_sync are already shared, so it is good to have a

[Qemu-devel] [PATCH 01/12] nbd: rename read_sync and friends

2017-05-31 Thread Vladimir Sementsov-Ogievskiy
Rename nbd_wr_syncv -> nbd_rwv read_sync -> nbd_read read_sync_eof -> nbd_read_eof write_sync -> nbd_write drop_sync -> nbd_drop 1. nbd_ prefix read_sync and write_sync are already shared, so it is good to have a namespace prefix. drop_sync will be shared, and read_sync_eof is