[Qemu-devel] [PATCH 02/19] usb-bus: convert USBDeviceClass init to realize

2014-09-18 Thread arei.gonglei
From: Gonglei arei.gong...@huawei.com Add realize/unrealize in USBDeviceClass, which has errp as a parameter. So all the implementations now use error_setg instead of error_report for reporting error. Note: this patch still keep init in USBDeviceClass, and call kclass-init in

Re: [Qemu-devel] [PATCH 02/19] usb-bus: convert USBDeviceClass init to realize

2014-09-18 Thread Paolo Bonzini
Il 18/09/2014 11:32, arei.gong...@huawei.com ha scritto: @@ -460,7 +460,7 @@ static void usb_serial_event(void *opaque, int event) break; case CHR_EVENT_OPENED: if (!s-dev.attached) { -usb_device_attach(s-dev); +

Re: [Qemu-devel] [PATCH 02/19] usb-bus: convert USBDeviceClass init to realize

2014-09-18 Thread Paolo Bonzini
Il 18/09/2014 11:32, arei.gong...@huawei.com ha scritto: static void usb_msd_password_cb(void *opaque, int err) { MSDState *s = opaque; +Error *local_err = NULL; -if (!err) -err = usb_device_attach(s-dev); +if (!err) { +usb_device_attach(s-dev,

Re: [Qemu-devel] [PATCH 02/19] usb-bus: convert USBDeviceClass init to realize

2014-09-18 Thread Gonglei (Arei)
From: Paolo Bonzini [mailto:pbonz...@redhat.com] Sent: Thursday, September 18, 2014 6:08 PM Subject: Re: [PATCH 02/19] usb-bus: convert USBDeviceClass init to realize Il 18/09/2014 11:32, arei.gong...@huawei.com ha scritto: @@ -460,7 +460,7 @@ static void usb_serial_event(void *opaque, int

Re: [Qemu-devel] [PATCH 02/19] usb-bus: convert USBDeviceClass init to realize

2014-09-18 Thread Gonglei (Arei)
From: Paolo Bonzini [mailto:pbonz...@redhat.com] Sent: Thursday, September 18, 2014 6:09 PM Subject: Re: [PATCH 02/19] usb-bus: convert USBDeviceClass init to realize Il 18/09/2014 11:32, arei.gong...@huawei.com ha scritto: static void usb_msd_password_cb(void *opaque, int err) {