Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Juan Quintela
Peter Maydell wrote: > On 7 April 2014 13:21, Markus Armbruster wrote: >> Peter Maydell writes: >> >>> On 7 April 2014 12:47, Juan Quintela wrote: Peter Maydell wrote: >>> Like I said, one patch per maintained subsystem, >>> one patch for the leftovers. >> >> Easier said than done. MAINT

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Juan Quintela
Markus Armbruster wrote: > Peter Maydell writes: > >> On 7 April 2014 12:47, Juan Quintela wrote: >>> Peter Maydell wrote: I'm really not a fan of this kind of single patch that touches a huge number of files at once. They're basically impossible to review and they introduce the

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Peter Maydell
On 7 April 2014 13:21, Markus Armbruster wrote: > Peter Maydell writes: > >> On 7 April 2014 12:47, Juan Quintela wrote: >>> Peter Maydell wrote: >> Like I said, one patch per maintained subsystem, >> one patch for the leftovers. > > Easier said than done. MAINTAINERS has more than 100 section

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Markus Armbruster
Peter Maydell writes: > On 7 April 2014 12:47, Juan Quintela wrote: >> Peter Maydell wrote: >>> I'm really not a fan of this kind of single patch that >>> touches a huge number of files at once. They're basically >>> impossible to review and they introduce the possibility >>> of conflicts betwe

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Peter Maydell
On 7 April 2014 12:47, Juan Quintela wrote: > Peter Maydell wrote: >> I'm really not a fan of this kind of single patch that >> touches a huge number of files at once. They're basically >> impossible to review and they introduce the possibility >> of conflicts between submaintainer tree changes a

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Juan Quintela
Peter Maydell wrote: > On 7 April 2014 04:20, Juan Quintela wrote: >> After previous Peter patch, they are redundant. This way we don't asign them >> except when needed. Once there, there were lots of case where the ".fields" >> indentation was wrong: >> >> .fields = (VMStateField []) { >>

Re: [Qemu-devel] [PATCH 02/97] savevm: Remove all the unneded version_minimum_id_old (Massive)

2014-04-07 Thread Peter Maydell
On 7 April 2014 04:20, Juan Quintela wrote: > After previous Peter patch, they are redundant. This way we don't asign them > except when needed. Once there, there were lots of case where the ".fields" > indentation was wrong: > > .fields = (VMStateField []) { > and > .fields = (VM