Re: [Qemu-devel] [PATCH 06/14] sdhci: refactor same sysbus/pci properties into a common one

2017-12-15 Thread Paolo Bonzini
On 14/12/2017 19:40, Philippe Mathieu-Daudé wrote: >>> +DEFINE_PROP_BOOL("pending-insert-quirk", SDHCIState, >>> pending_insert_quirk, >>> + false), >> I like the reduction of code in this patch, but aren't we now going to >> have device properties that aren't actually

Re: [Qemu-devel] [PATCH 06/14] sdhci: refactor same sysbus/pci properties into a common one

2017-12-14 Thread Kevin O'Connor
On Thu, Dec 14, 2017 at 03:40:17PM -0300, Philippe Mathieu-Daudé wrote: > >> /* Capabilities registers provide information on supported features of > >> this > >> * specific host controller implementation */ > >> -static Property sdhci_pci_properties[] = { > >> +static Property

Re: [Qemu-devel] [PATCH 06/14] sdhci: refactor same sysbus/pci properties into a common one

2017-12-14 Thread Alistair Francis
On Thu, Dec 14, 2017 at 10:40 AM, Philippe Mathieu-Daudé wrote: >>> /* Capabilities registers provide information on supported features of this >>> * specific host controller implementation */ >>> -static Property sdhci_pci_properties[] = { >>> +static Property

Re: [Qemu-devel] [PATCH 06/14] sdhci: refactor same sysbus/pci properties into a common one

2017-12-14 Thread Philippe Mathieu-Daudé
>> /* Capabilities registers provide information on supported features of this >> * specific host controller implementation */ >> -static Property sdhci_pci_properties[] = { >> +static Property sdhci_properties[] = { >> DEFINE_PROP_UINT32("capareg", SDHCIState, capareg, >>

Re: [Qemu-devel] [PATCH 06/14] sdhci: refactor same sysbus/pci properties into a common one

2017-12-14 Thread Alistair Francis
On Wed, Dec 13, 2017 at 11:58 AM, Philippe Mathieu-Daudé wrote: > add sysbus/pci/sdbus separator comments to keep it clearer > > Signed-off-by: Philippe Mathieu-Daudé > --- > hw/sd/sdhci.c | 21 ++--- > 1 file changed, 10 insertions(+), 11

[Qemu-devel] [PATCH 06/14] sdhci: refactor same sysbus/pci properties into a common one

2017-12-13 Thread Philippe Mathieu-Daudé
add sysbus/pci/sdbus separator comments to keep it clearer Signed-off-by: Philippe Mathieu-Daudé --- hw/sd/sdhci.c | 21 ++--- 1 file changed, 10 insertions(+), 11 deletions(-) diff --git a/hw/sd/sdhci.c b/hw/sd/sdhci.c index a56c0c273e..c8b7b1ca4c 100644 ---