Re: [Qemu-devel] [PATCH 1/2] Add "directio" parameter to "-drive"

2007-11-29 Thread Balazs Attila-Mihaly (Cd-MaN)
Le mercredi 28 novembre 2007 à 14:24 +, Samuel Thibault a écrit : > Hi, > > Laurent Vivier, le Wed 28 Nov 2007 15:02:50 +0100, a écrit : > > +ret = posix_memalign((void**)&buf, 0x200, 512); > > For making this more easily portable, maybe it should be a new > qemu_memalign() function? Al

Re: [Qemu-devel] [PATCH 1/2] Add "directio" parameter to "-drive"

2007-11-29 Thread Laurent Vivier
Le mercredi 28 novembre 2007 à 14:24 +, Samuel Thibault a écrit : > Hi, > > Laurent Vivier, le Wed 28 Nov 2007 15:02:50 +0100, a écrit : > > +ret = posix_memalign((void**)&buf, 0x200, 512); > > For making this more easily portable, maybe it should be a new > qemu_memalign() function? Als

Re: [Qemu-devel] [PATCH 1/2] Add "directio" parameter to "-drive"

2007-11-28 Thread Samuel Thibault
Laurent Vivier, le Wed 28 Nov 2007 16:00:17 +0100, a écrit : > Le mercredi 28 novembre 2007 à 14:24 +, Samuel Thibault a écrit : > > Laurent Vivier, le Wed 28 Nov 2007 15:02:50 +0100, a écrit : > > > +ret = posix_memalign((void**)&buf, 0x200, 512); > > > > For making this more easily porta

Re: [Qemu-devel] [PATCH 1/2] Add "directio" parameter to "-drive"

2007-11-28 Thread Laurent Vivier
Le mercredi 28 novembre 2007 à 14:24 +, Samuel Thibault a écrit : > Hi, > > Laurent Vivier, le Wed 28 Nov 2007 15:02:50 +0100, a écrit : > > +ret = posix_memalign((void**)&buf, 0x200, 512); > > For making this more easily portable, maybe it should be a new > qemu_memalign() function? Als

Re: [Qemu-devel] [PATCH 1/2] Add "directio" parameter to "-drive"

2007-11-28 Thread Samuel Thibault
Hi, Laurent Vivier, le Wed 28 Nov 2007 15:02:50 +0100, a écrit : > +ret = posix_memalign((void**)&buf, 0x200, 512); For making this more easily portable, maybe it should be a new qemu_memalign() function? Also, the alignment may probably be better as a global macro, since the alignment requi

[Qemu-devel] [PATCH 1/2] Add "directio" parameter to "-drive"

2007-11-28 Thread Laurent Vivier
This patch add a new parameter to "-drive" Using "directio=on" with "-drive" will open the disk image file using "O_DIRECT". By default, "directio" is set to "off". example: "-drive file=my_disk.qcow2,directio=on" --- block-raw.c|4 block.c|2 +- block.h|1