Re: [Qemu-devel] [PATCH 1/2] Detect and use GCC atomic builtins for locking

2010-02-27 Thread Paul Brook
diff --git a/qemu-lock.h b/qemu-lock.h This code isn't used in any interesting ways, it should be removed.. Paul

Re: [Qemu-devel] [PATCH 1/2] Detect and use GCC atomic builtins for locking

2010-02-22 Thread Loïc Minier
On Sat, Feb 20, 2010, malc wrote: No, i'm against using locking GCC builtins for all the other targets (well PPC) Do you have benchmarks with/without GCC atomic builtins? -- Loïc Minier

Re: [Qemu-devel] [PATCH 1/2] Detect and use GCC atomic builtins for locking

2010-02-22 Thread malc
On Mon, 22 Feb 2010, Lo?c Minier wrote: On Sat, Feb 20, 2010, malc wrote: No, i'm against using locking GCC builtins for all the other targets (well PPC) Do you have benchmarks with/without GCC atomic builtins? No. -- mailto:av1...@comtv.ru

Re: [Qemu-devel] [PATCH 1/2] Detect and use GCC atomic builtins for locking

2010-02-20 Thread Loïc Minier
NB: Addition of these builtins was prompted by qemu failing to build on armel in Ubuntu; this is because we default to Thumb 2 mode which doesn't have the assembly instructions in question.

Re: [Qemu-devel] [PATCH 1/2] Detect and use GCC atomic builtins for locking

2010-02-20 Thread malc
On Sat, 20 Feb 2010, Lo?c Minier wrote: NB: Addition of these builtins was prompted by qemu failing to build on armel in Ubuntu; this is because we default to Thumb 2 mode which doesn't have the assembly instructions in question.

Re: [Qemu-devel] [PATCH 1/2] Detect and use GCC atomic builtins for locking

2010-02-20 Thread Loïc Minier
On Sat, Feb 20, 2010, malc wrote: For instance this: http://sources.redhat.com/ml/libc-alpha/2005-06/msg00112.html The builtins are too coarse grained and will do more stuff than strictly necessary. Is this the case of the builtins I'm proposing to use? We could ask for new ones without

Re: [Qemu-devel] [PATCH 1/2] Detect and use GCC atomic builtins for locking

2010-02-20 Thread malc
On Sat, 20 Feb 2010, Lo?c Minier wrote: On Sat, Feb 20, 2010, malc wrote: For instance this: http://sources.redhat.com/ml/libc-alpha/2005-06/msg00112.html The builtins are too coarse grained and will do more stuff than strictly necessary. Is this the case of the builtins I'm

[Qemu-devel] [PATCH 1/2] Detect and use GCC atomic builtins for locking

2010-02-19 Thread Loïc Minier
--- configure | 17 + qemu-lock.h | 13 + 2 files changed, 30 insertions(+), 0 deletions(-) diff --git a/configure b/configure index 0a84b0e..b33f045 100755 --- a/configure +++ b/configure @@ -1823,6 +1823,20 @@ if compile_prog ; then fi

Re: [Qemu-devel] [PATCH 1/2] Detect and use GCC atomic builtins for locking

2010-02-19 Thread malc
On Fri, 19 Feb 2010, Lo?c Minier wrote: Please look up gcc 4.1 implements compiler builtins for atomic ops thread for reasons why this might not be the best idea. [..snip..] -- mailto:av1...@comtv.ru