Seems arm_cpu_do_unaligned_access() function could use it. It uses
cpu_mmu_index() for now but I think use of mmu_idx is preferred. Anyway it's
the subject for another patch.
13.06.2016, 10:47, "Aurelien Jarno" :
> On 2016-06-10 19:26, Sergey Sorokin wrote:
>> There are functions cpu_unaligned_
On 10/06/2016 19:26, Sergey Sorokin wrote:
> cpu-common.h is not included in qom/cpu.h what do you think? Should
> it be included? Or may be MMUAccessType should be just moved into
> another header. For example into exec/memattrs.h
You can move it to qom/cpu.h.
Paolo
On 2016-06-10 19:26, Sergey Sorokin wrote:
> There are functions cpu_unaligned_access() and do_unaligned_access() that
> are called with access type and mmu index arguments. But these arguments
> are named 'is_write' and 'is_user' in their declarations.
> The patch fixes the names to avoid a confus
cpu-common.h is not included in qom/cpu.h
what do you think? Should it be included? Or may be MMUAccessType should be
just moved into another header. For example into exec/memattrs.h
10.06.2016, 19:44, "Peter Maydell" :
> On 10 June 2016 at 17:42, Sergey Sorokin wrote:
>> What if I combine both
On 10 June 2016 at 17:42, Sergey Sorokin wrote:
> What if I combine both patches into single one?
No particular objection.
-- PMM
What if I combine both patches into single one?
10.06.2016, 19:33, "Peter Maydell" :
> On 10 June 2016 at 17:26, Sergey Sorokin wrote:
>> There are functions cpu_unaligned_access() and do_unaligned_access() that
>> are called with access type and mmu index arguments. But these arguments
>> are
I agree
10.06.2016, 19:33, "Peter Maydell" :
> On 10 June 2016 at 17:26, Sergey Sorokin wrote:
>> There are functions cpu_unaligned_access() and do_unaligned_access() that
>> are called with access type and mmu index arguments. But these arguments
>> are named 'is_write' and 'is_user' in their
On 10 June 2016 at 17:26, Sergey Sorokin wrote:
> There are functions cpu_unaligned_access() and do_unaligned_access() that
> are called with access type and mmu index arguments. But these arguments
> are named 'is_write' and 'is_user' in their declarations.
> The patch fixes the names to avoid a
There are functions cpu_unaligned_access() and do_unaligned_access() that
are called with access type and mmu index arguments. But these arguments
are named 'is_write' and 'is_user' in their declarations.
The patch fixes the names to avoid a confusion.
Signed-off-by: Sergey Sorokin
---
include/q
