Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501) v2

2012-10-09 Thread Jan Kiszka
On 2012-10-09 15:03, Lucas Meneghel Rodrigues wrote: > From: Hervé Poussineau > > Add generic support for simple I/O port which, when written to, cause > QEMU to exit with the given written value. > > There is no vmstate associated with the debugging port, simply because > the entire interface i

[Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501) v2

2012-10-09 Thread Lucas Meneghel Rodrigues
From: Hervé Poussineau Add generic support for simple I/O port which, when written to, cause QEMU to exit with the given written value. There is no vmstate associated with the debugging port, simply because the entire interface is a single, stateless, write-only port. Changes from v1: * Chang

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Blue Swirl
On Fri, Oct 5, 2012 at 2:15 PM, Paolo Bonzini wrote: > Il 05/10/2012 15:58, Anthony Liguori ha scritto: >> Paolo Bonzini writes: >> >>> Il 05/10/2012 14:43, Jan Kiszka ha scritto: This "| 1" might be the problem. Anthony, are you relying on it in qemu-test and/or can you work o

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 16:23, Anthony Liguori ha scritto: >> > Understood. The right solution is of course to fix hw/*.c. > I don't think it's an awful thing for test harnesses to just use a > reserved range of exit reasons. But that's not what exit((val << 1) | 1) does, since it allows you to do exit(1).

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Anthony Liguori
Paolo Bonzini writes: > Il 05/10/2012 15:58, Anthony Liguori ha scritto: >> Paolo Bonzini writes: >> >>> Il 05/10/2012 14:43, Jan Kiszka ha scritto: This "| 1" might be the problem. Anthony, are you relying on it in qemu-test and/or can you work out the changes if we use just

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 15:58, Anthony Liguori ha scritto: > Paolo Bonzini writes: > >> Il 05/10/2012 14:43, Jan Kiszka ha scritto: >>> This "| 1" might be the problem. Anthony, are you relying on it in >>> qemu-test and/or can you work out the changes if we use just >>> "exit(val)"? > >>>

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Anthony Liguori
Paolo Bonzini writes: > Il 05/10/2012 14:43, Jan Kiszka ha scritto: >> This "| 1" might be the problem. Anthony, are you relying on it in >> qemu-test and/or can you work out the changes if we use just >> "exit(val)"? >>> > >>> > The reason for ' | 1' was to make sure that the gu

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Jan Kiszka
On 2012-10-05 14:46, Paolo Bonzini wrote: > Il 05/10/2012 14:43, Jan Kiszka ha scritto: >> This "| 1" might be the problem. Anthony, are you relying on it in >> qemu-test and/or can you work out the changes if we use just >> "exit(val)"? The reason for ' | 1' was to make sure

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Paolo Bonzini
Il 05/10/2012 14:43, Jan Kiszka ha scritto: >>> >> This "| 1" might be the problem. Anthony, are you relying on it in >>> >> qemu-test and/or can you work out the changes if we use just >>> >> "exit(val)"? >> > >> > The reason for ' | 1' was to make sure that the guest couldn't trigger >> > an ex

Re: [Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-05 Thread Jan Kiszka
[was a private thread due to typo in qemu list address] On 2012-10-05 14:40, Anthony Liguori wrote: > Paolo Bonzini writes: > >> Il 05/10/2012 00:06, Lucas Meneghel Rodrigues ha scritto: >>> +static void debugexit_ioport_write(void *opaque, uint32_t addr, uint32_t >>> val) >>> +{ >>> +exit(

[Qemu-devel] [PATCH 1/2] debugexit: support for custom exit port (LGPL VGA BIOS port 0x501)

2012-10-04 Thread Lucas Meneghel Rodrigues
From: Hervé Poussineau Add generic support for simple I/O port which, when written to, cause QEMU to exit with the given written value. There is no vmstate associated with the debugging port, simply because the entire interface is a single, stateless, write-only port. Signed-off-by: Hervé Pouss