Re: [Qemu-devel] [PATCH 1/2] iotests: Fix test 156

2017-07-26 Thread Jeff Cody
On Tue, Jul 25, 2017 at 05:56:43PM +0200, Max Reitz wrote: > On one hand, the _make_test_img invocation for creating the target image > was missing a -u because its backing file is not supposed to exist at > that point. > > On the other hand, nobody noticed probably because the backing file is > c

Re: [Qemu-devel] [PATCH 1/2] iotests: Fix test 156

2017-07-25 Thread Eric Blake
On 07/25/2017 10:56 AM, Max Reitz wrote: > On one hand, the _make_test_img invocation for creating the target image > was missing a -u because its backing file is not supposed to exist at > that point. > > On the other hand, nobody noticed probably because the backing file is > created later on an

[Qemu-devel] [PATCH 1/2] iotests: Fix test 156

2017-07-25 Thread Max Reitz
On one hand, the _make_test_img invocation for creating the target image was missing a -u because its backing file is not supposed to exist at that point. On the other hand, nobody noticed probably because the backing file is created later on and _cleanup failed to remove it: The quotation marks w