Re: [Qemu-devel] [PATCH 1/2] net/vmxnet3: fix debug macro pattern for vmxnet3

2015-12-04 Thread Miao Yan
2015-12-04 21:18 GMT+08:00 Eric Blake : > On 12/04/2015 02:19 AM, Miao Yan wrote: >> Vmxnet3 uses the following debug macro style: >> > > When sending a patch series, it's best to include a 0/2 cover letter > (some of the maintainer tooling works better if it can reply to the > cover letter). > > A

Re: [Qemu-devel] [PATCH 1/2] net/vmxnet3: fix debug macro pattern for vmxnet3

2015-12-04 Thread Eric Blake
On 12/04/2015 02:19 AM, Miao Yan wrote: > Vmxnet3 uses the following debug macro style: > When sending a patch series, it's best to include a 0/2 cover letter (some of the maintainer tooling works better if it can reply to the cover letter). Also, this patch depends on your earlier patch "net/vm

[Qemu-devel] [PATCH 1/2] net/vmxnet3: fix debug macro pattern for vmxnet3

2015-12-04 Thread Miao Yan
Vmxnet3 uses the following debug macro style: #ifdef SOME_DEBUG # define debug(...) do{ printf(...); } while (0) # else # define debug(...) do{ } while (0) #endif If SOME_DEBUG is undefined, then format string inside the debug macro will never be checked by compiler. Code will likely to br