Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-10-20 Thread Cornelia Huck
On Fri, 20 Oct 2017 16:33:47 +0200 Halil Pasic wrote: > OK, I will approach the z/VM guys. About EMULATED_CCW_3270_CHPID_TYPE, > does it really make sense to have a separate chpid type for 3270? (You > have missed that question, so I'm asking it again). I had not. But

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-10-20 Thread Halil Pasic
On 10/20/2017 03:00 PM, Cornelia Huck wrote: > On Thu, 19 Oct 2017 18:39:37 +0200 > Halil Pasic wrote: > >> On 09/15/2017 09:27 AM, Cornelia Huck wrote: > >> +DEFINE_PROP_UINT8("chpid_type", CcwTesterDevice, chpid_type, >> +

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-10-20 Thread Cornelia Huck
On Thu, 19 Oct 2017 18:39:37 +0200 Halil Pasic wrote: > On 09/15/2017 09:27 AM, Cornelia Huck wrote: > >>> > +DEFINE_PROP_UINT8("chpid_type", CcwTesterDevice, chpid_type, > + 0x98), > > This might also need re-evaluation - we

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-10-19 Thread Halil Pasic
On 09/15/2017 09:27 AM, Cornelia Huck wrote: >>> +DEFINE_PROP_UINT8("chpid_type", CcwTesterDevice, chpid_type, + 0x98), > This might also need re-evaluation - we should not really need a new > chpid type. > I'm back at ccw-tester again (for v2). I've

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-09-25 Thread Cornelia Huck
On Mon, 25 Sep 2017 17:06:01 +0200 Halil Pasic wrote: > @Connie > I would also like to have an account. Done (for both of you). > I would also like to do a > v2 of this somewhere in the not too distant future. I intend > to address the issues pointed out by you here

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-09-25 Thread Halil Pasic
On 09/19/2017 04:20 PM, Pierre Morel wrote: > On 15/09/2017 19:01, Cornelia Huck wrote: >> On Fri, 15 Sep 2017 09:27:58 +0200 >> Cornelia Huck wrote: >> >>> On Thu, 14 Sep 2017 18:50:29 +0200 >>> Halil Pasic wrote: >>> On 09/14/2017 04:26 PM,

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-09-19 Thread Pierre Morel
On 14/09/2017 16:26, Cornelia Huck wrote: On Wed, 13 Sep 2017 15:27:51 +0200 Halil Pasic wrote: Add a fake device meant for testing the correctness of our css emulation. What we currently have is writing a Fibonacci sequence of uint32_t to the device via ccw write.

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-09-19 Thread Pierre Morel
On 15/09/2017 19:01, Cornelia Huck wrote: On Fri, 15 Sep 2017 09:27:58 +0200 Cornelia Huck wrote: On Thu, 14 Sep 2017 18:50:29 +0200 Halil Pasic wrote: On 09/14/2017 04:26 PM, Cornelia Huck wrote: There's quite some potential in this. We may

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-09-18 Thread Cornelia Huck
On Mon, 18 Sep 2017 10:30:32 +0200 Christian Borntraeger wrote: > On 09/15/2017 09:27 AM, Cornelia Huck wrote: > > On Thu, 14 Sep 2017 18:50:29 +0200 > > Halil Pasic wrote: > > > >> On 09/14/2017 04:26 PM, Cornelia Huck wrote: > >>> On Wed,

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-09-18 Thread Christian Borntraeger
On 09/15/2017 09:27 AM, Cornelia Huck wrote: > On Thu, 14 Sep 2017 18:50:29 +0200 > Halil Pasic wrote: > >> On 09/14/2017 04:26 PM, Cornelia Huck wrote: >>> On Wed, 13 Sep 2017 15:27:51 +0200 >>> Halil Pasic wrote: > +static Property

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-09-15 Thread Cornelia Huck
On Fri, 15 Sep 2017 09:27:58 +0200 Cornelia Huck wrote: > On Thu, 14 Sep 2017 18:50:29 +0200 > Halil Pasic wrote: > > > On 09/14/2017 04:26 PM, Cornelia Huck wrote: > > > There's quite some potential in this. We may want to make this a > > >

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-09-15 Thread Cornelia Huck
On Thu, 14 Sep 2017 18:50:29 +0200 Halil Pasic wrote: > On 09/14/2017 04:26 PM, Cornelia Huck wrote: > > On Wed, 13 Sep 2017 15:27:51 +0200 > > Halil Pasic wrote: > >> +static Property ccw_tester_properties[] = { > >> +

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-09-14 Thread Halil Pasic
On 09/14/2017 04:26 PM, Cornelia Huck wrote: > On Wed, 13 Sep 2017 15:27:51 +0200 > Halil Pasic wrote: > >> Add a fake device meant for testing the correctness of our css emulation. >> >> What we currently have is writing a Fibonacci sequence of uint32_t to the >>

Re: [Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-09-14 Thread Cornelia Huck
On Wed, 13 Sep 2017 15:27:51 +0200 Halil Pasic wrote: > Add a fake device meant for testing the correctness of our css emulation. > > What we currently have is writing a Fibonacci sequence of uint32_t to the > device via ccw write. The write is going to fail if it

[Qemu-devel] [PATCH 1/2] s390x/ccs: add ccw-tester emulated device

2017-09-13 Thread Halil Pasic
Add a fake device meant for testing the correctness of our css emulation. What we currently have is writing a Fibonacci sequence of uint32_t to the device via ccw write. The write is going to fail if it ain't a Fibonacci and indicate a device exception in scsw together with the proper residual