Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-14 Thread Jason Wang
On 2017年02月14日 15:33, Hailiang Zhang wrote: On 2017/2/14 12:08, Jason Wang wrote: On 2017年02月14日 10:32, Hailiang Zhang wrote: Hi Jason, I think the better way is notify the comparing thread and let it do the releasing. You probably need similar mechanism to notify from comparing th

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-13 Thread Hailiang Zhang
On 2017/2/14 12:08, Jason Wang wrote: On 2017年02月14日 10:32, Hailiang Zhang wrote: Hi Jason, I think the better way is notify the comparing thread and let it do the releasing. You probably need similar mechanism to notify from comparing thread to checkpoint thread. It seems that there

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-13 Thread Jason Wang
On 2017年02月14日 10:32, Hailiang Zhang wrote: Hi Jason, I think the better way is notify the comparing thread and let it do the releasing. You probably need similar mechanism to notify from comparing thread to checkpoint thread. It seems that there is no available APIs in glib to notify

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-13 Thread Hailiang Zhang
On 2017/2/7 17:21, Jason Wang wrote: On 2017年02月07日 16:19, Hailiang Zhang wrote: On 2017/2/7 15:57, Jason Wang wrote: On 2017年02月07日 15:54, Hailiang Zhang wrote: Hi Jason, On 2017/2/6 20:53, Jason Wang wrote: On 2017年02月06日 19:11, Hailiang Zhang wrote: On 2017/2/6 17:35, Jason Wang wr

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-07 Thread Hailiang Zhang
On 2017/2/7 17:21, Jason Wang wrote: On 2017年02月07日 16:19, Hailiang Zhang wrote: On 2017/2/7 15:57, Jason Wang wrote: On 2017年02月07日 15:54, Hailiang Zhang wrote: Hi Jason, On 2017/2/6 20:53, Jason Wang wrote: On 2017年02月06日 19:11, Hailiang Zhang wrote: On 2017/2/6 17:35, Jason Wang wr

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-07 Thread Jason Wang
On 2017年02月07日 16:19, Hailiang Zhang wrote: On 2017/2/7 15:57, Jason Wang wrote: On 2017年02月07日 15:54, Hailiang Zhang wrote: Hi Jason, On 2017/2/6 20:53, Jason Wang wrote: On 2017年02月06日 19:11, Hailiang Zhang wrote: On 2017/2/6 17:35, Jason Wang wrote: On 2017年02月06日 16:13, Hailiang

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-07 Thread Hailiang Zhang
On 2017/2/7 15:57, Jason Wang wrote: On 2017年02月07日 15:54, Hailiang Zhang wrote: Hi Jason, On 2017/2/6 20:53, Jason Wang wrote: On 2017年02月06日 19:11, Hailiang Zhang wrote: On 2017/2/6 17:35, Jason Wang wrote: On 2017年02月06日 16:13, Hailiang Zhang wrote: On 2017/2/3 11:47, Jason Wang wr

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-06 Thread Jason Wang
On 2017年02月07日 15:54, Hailiang Zhang wrote: Hi Jason, On 2017/2/6 20:53, Jason Wang wrote: On 2017年02月06日 19:11, Hailiang Zhang wrote: On 2017/2/6 17:35, Jason Wang wrote: On 2017年02月06日 16:13, Hailiang Zhang wrote: On 2017/2/3 11:47, Jason Wang wrote: On 2017年01月24日 22:05, zhanghai

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-06 Thread Hailiang Zhang
Hi Jason, On 2017/2/6 20:53, Jason Wang wrote: On 2017年02月06日 19:11, Hailiang Zhang wrote: On 2017/2/6 17:35, Jason Wang wrote: On 2017年02月06日 16:13, Hailiang Zhang wrote: On 2017/2/3 11:47, Jason Wang wrote: On 2017年01月24日 22:05, zhanghailiang wrote: The original 'timer_check_lock' m

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-06 Thread Jason Wang
On 2017年02月06日 19:11, Hailiang Zhang wrote: On 2017/2/6 17:35, Jason Wang wrote: On 2017年02月06日 16:13, Hailiang Zhang wrote: On 2017/2/3 11:47, Jason Wang wrote: On 2017年01月24日 22:05, zhanghailiang wrote: The original 'timer_check_lock' mutex lock of struct CompareState is used to prote

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-06 Thread Hailiang Zhang
On 2017/2/6 17:35, Jason Wang wrote: On 2017年02月06日 16:13, Hailiang Zhang wrote: On 2017/2/3 11:47, Jason Wang wrote: On 2017年01月24日 22:05, zhanghailiang wrote: The original 'timer_check_lock' mutex lock of struct CompareState is used to protect the 'conn_list' queue and its child queues w

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-06 Thread Jason Wang
On 2017年02月06日 16:13, Hailiang Zhang wrote: On 2017/2/3 11:47, Jason Wang wrote: On 2017年01月24日 22:05, zhanghailiang wrote: The original 'timer_check_lock' mutex lock of struct CompareState is used to protect the 'conn_list' queue and its child queues which are 'primary_list' and 'secondary

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-06 Thread Zhang Chen
On 02/06/2017 04:13 PM, Hailiang Zhang wrote: On 2017/2/3 11:47, Jason Wang wrote: On 2017年01月24日 22:05, zhanghailiang wrote: The original 'timer_check_lock' mutex lock of struct CompareState is used to protect the 'conn_list' queue and its child queues which are 'primary_list' and 'seconda

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-06 Thread Hailiang Zhang
On 2017/2/3 11:47, Jason Wang wrote: On 2017年01月24日 22:05, zhanghailiang wrote: The original 'timer_check_lock' mutex lock of struct CompareState is used to protect the 'conn_list' queue and its child queues which are 'primary_list' and 'secondary_list', which is a little abused and confusing

Re: [Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-02-02 Thread Jason Wang
On 2017年01月24日 22:05, zhanghailiang wrote: The original 'timer_check_lock' mutex lock of struct CompareState is used to protect the 'conn_list' queue and its child queues which are 'primary_list' and 'secondary_list', which is a little abused and confusing To make it clearer, we rename 'timer_

[Qemu-devel] [PATCH 1/3] colo-compare: reconstruct the mutex lock usage

2017-01-24 Thread zhanghailiang
The original 'timer_check_lock' mutex lock of struct CompareState is used to protect the 'conn_list' queue and its child queues which are 'primary_list' and 'secondary_list', which is a little abused and confusing To make it clearer, we rename 'timer_check_lock' to 'conn_list_lock' which is used t