Re: [Qemu-devel] [PATCH 1/3] s390x/css: use macro for event-information pending error recover code

2017-07-28 Thread Cornelia Huck
On Fri, 28 Jul 2017 15:12:25 +0800 Dong Jia Shi wrote: > * Cornelia Huck [2017-07-27 12:10:17 +0200]: > > Do we want to add all ERCs while we're at it? > > > > > +#define CRW_ERC_INIT 0x02 > > > +#define CRW_ERC_IPI0x04 > No problem

Re: [Qemu-devel] [PATCH 1/3] s390x/css: use macro for event-information pending error recover code

2017-07-28 Thread Dong Jia Shi
* Cornelia Huck [2017-07-27 12:10:17 +0200]: [...] > > diff --git a/include/hw/s390x/ioinst.h b/include/hw/s390x/ioinst.h > > index 92d15655e4..c1d1052279 100644 > > --- a/include/hw/s390x/ioinst.h > > +++ b/include/hw/s390x/ioinst.h > > @@ -201,8 +201,9 @@ typedef struct CRW

Re: [Qemu-devel] [PATCH 1/3] s390x/css: use macro for event-information pending error recover code

2017-07-27 Thread Cornelia Huck
On Thu, 27 Jul 2017 03:54:16 +0200 Dong Jia Shi wrote: > Let's use a macro for the ERC (error recover code) when generating a > Channel Subsystem Event-information pending CRW (channel report word). Sounds reasonable. > > Signed-off-by: Dong Jia Shi

[Qemu-devel] [PATCH 1/3] s390x/css: use macro for event-information pending error recover code

2017-07-26 Thread Dong Jia Shi
Let's use a macro for the ERC (error recover code) when generating a Channel Subsystem Event-information pending CRW (channel report word). Signed-off-by: Dong Jia Shi --- hw/s390x/css.c| 2 +- include/hw/s390x/ioinst.h | 5 +++-- 2 files changed, 4