Re: [Qemu-devel] [PATCH 1/3] virtio pmem: fix wrong mem region condition

2019-07-14 Thread David Hildenbrand
On 12.07.19 09:35, Pankaj Gupta wrote: > Coverity reported memory region returns zero > for non-null value. This is because of wrong > arguments to '?:' , fixing this. > > Signed-off-by: Pankaj Gupta > --- > hw/virtio/virtio-pmem-pci.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [Qemu-devel] [PATCH 1/3] virtio pmem: fix wrong mem region condition

2019-07-12 Thread Philippe Mathieu-Daudé
On 7/12/19 9:35 AM, Pankaj Gupta wrote: > Coverity reported memory region returns zero > for non-null value. This is because of wrong > arguments to '?:' , fixing this. > Please amend: Fixes: Coverity (CID 1403009) > Signed-off-by: Pankaj Gupta Reviewed-by: Philippe Mathieu-Daudé Tested-by:

Re: [Qemu-devel] [PATCH 1/3] virtio pmem: fix wrong mem region condition

2019-07-12 Thread Cornelia Huck
On Fri, 12 Jul 2019 13:05:52 +0530 Pankaj Gupta wrote: > Coverity reported memory region returns zero > for non-null value. This is because of wrong > arguments to '?:' , fixing this. > > Signed-off-by: Pankaj Gupta > --- > hw/virtio/virtio-pmem-pci.c | 2 +- > 1 file changed, 1 insertion(+),

Re: [Qemu-devel] [PATCH 1/3] virtio pmem: fix wrong mem region condition

2019-07-12 Thread Stefano Garzarella
On Fri, Jul 12, 2019 at 01:05:52PM +0530, Pankaj Gupta wrote: > Coverity reported memory region returns zero > for non-null value. This is because of wrong > arguments to '?:' , fixing this. > > Signed-off-by: Pankaj Gupta > --- > hw/virtio/virtio-pmem-pci.c | 2 +- > 1 file changed, 1 insertion

[Qemu-devel] [PATCH 1/3] virtio pmem: fix wrong mem region condition

2019-07-12 Thread Pankaj Gupta
Coverity reported memory region returns zero for non-null value. This is because of wrong arguments to '?:' , fixing this. Signed-off-by: Pankaj Gupta --- hw/virtio/virtio-pmem-pci.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/hw/virtio/virtio-pmem-pci.c b/hw/virtio/virti