Re: [Qemu-devel] [PATCH 1/6] ahci: move PIO Setup FIS before transfer, fix it for ATAPI commands

2018-06-06 Thread Paolo Bonzini
On 05/06/2018 01:27, John Snow wrote: > > > On 06/04/2018 11:50 AM, Paolo Bonzini wrote: >> On 02/06/2018 03:22, John Snow wrote: >>> - Status: Should be the status register after receiving the H2D Register >>> update FIS, but prior to the data transfer, I think. "New value of the >>> Status

Re: [Qemu-devel] [PATCH 1/6] ahci: move PIO Setup FIS before transfer, fix it for ATAPI commands

2018-06-04 Thread John Snow
On 06/04/2018 11:50 AM, Paolo Bonzini wrote: > On 02/06/2018 03:22, John Snow wrote: >> - Status: Should be the status register after receiving the H2D Register >> update FIS, but prior to the data transfer, I think. "New value of the >> Status register of the Command Block for initiation of

Re: [Qemu-devel] [PATCH 1/6] ahci: move PIO Setup FIS before transfer, fix it for ATAPI commands

2018-06-04 Thread Paolo Bonzini
On 02/06/2018 03:22, John Snow wrote: > - Status: Should be the status register after receiving the H2D Register > update FIS, but prior to the data transfer, I think. "New value of the > Status register of the Command Block for initiation of host data > transfer." > I think this is being s

Re: [Qemu-devel] [PATCH 1/6] ahci: move PIO Setup FIS before transfer, fix it for ATAPI commands

2018-06-01 Thread John Snow
On 04/17/2018 11:39 AM, Paolo Bonzini wrote: > The PIO Setup FIS is written in the PIO:Entry state, which comes before > the ATA and ATAPI data transfer states. As a result, the PIO Setup FIS > interrupt is now raised before DMA ends for ATAPI commands, and tests have > to be adjusted. > Yes,

[Qemu-devel] [PATCH 1/6] ahci: move PIO Setup FIS before transfer, fix it for ATAPI commands

2018-04-17 Thread Paolo Bonzini
The PIO Setup FIS is written in the PIO:Entry state, which comes before the ATA and ATAPI data transfer states. As a result, the PIO Setup FIS interrupt is now raised before DMA ends for ATAPI commands, and tests have to be adjusted. This is also hinted by the description of the command header in