On 17/05/19 06:35, Jason Wang wrote:
>> Yes, your honor. :) The helper is the only way for unprivileged users
>> to set up TAP networking, which is basically the only really way to have
>> *working* network. It's widely used in the wild, it's self-contained
>> and the only alternative for users
On 2019/5/15 下午9:35, Paolo Bonzini wrote:
On 15/05/19 08:34, Markus Armbruster wrote:
qemu-bridge-helper should have a manual page, and its handling of errors
in ACL include files needs work. There's probably more; I just glanced
at it. I'm not volunteering, though. It lacks a maintainer.
On 5/15/19 9:55 AM, Markus Armbruster wrote:
> Proposal:
>
> 1. Add qemu-bridge-helper.c to Jason's "Network device backends"
>
> 2. Deprecate -netdev tap parameter "helper"
>
> 3. Improve documentation of -netdev bridge
>
> 4. Create a manual page for qemu-bridge-helper that also covers
>
Markus Armbruster writes:
> Daniel P. Berrangé writes:
>
>> On Wed, May 15, 2019 at 08:34:17AM +0200, Markus Armbruster wrote:
>>> Jason Wang writes:
>>>
>>> > On 2019/5/14 下午8:18, Markus Armbruster wrote:
>>> >> Peter Maydell writes:
>>> >>
>>> >>> On Mon, 13 May 2019 at 14:21, Markus
On 5/15/19 7:54 AM, Markus Armbruster wrote:
> We don't want to deprecate qemu-bridge-helper while libvirt has a
> sensible use for it.
>
> We can still deprecate -netdev tap parameter "helper" and -netdev bridge
> entirely.
>
> Once they're gone, qemu-bridge-helper wull have no user within
Daniel P. Berrangé writes:
> On Wed, May 15, 2019 at 08:34:17AM +0200, Markus Armbruster wrote:
>> Jason Wang writes:
>>
>> > On 2019/5/14 下午8:18, Markus Armbruster wrote:
>> >> Peter Maydell writes:
>> >>
>> >>> On Mon, 13 May 2019 at 14:21, Markus Armbruster
>> >>> wrote:
>> Perhaps
On Wed, May 15, 2019 at 04:54:04PM +0200, Markus Armbruster wrote:
> Daniel P. Berrangé writes:
>
> > On Wed, May 15, 2019 at 08:34:17AM +0200, Markus Armbruster wrote:
> >> Jason Wang writes:
> >>
> >> > On 2019/5/14 下午8:18, Markus Armbruster wrote:
> >> >> Peter Maydell writes:
> >> >>
> >>
On 15/05/19 08:34, Markus Armbruster wrote:
>>> qemu-bridge-helper should have a manual page, and its handling of errors
>>> in ACL include files needs work. There's probably more; I just glanced
>>> at it. I'm not volunteering, though. It lacks a maintainer. Should we
>>> add it to Jason's
On Wed, May 15, 2019 at 08:34:17AM +0200, Markus Armbruster wrote:
> Jason Wang writes:
>
> > On 2019/5/14 下午8:18, Markus Armbruster wrote:
> >> Peter Maydell writes:
> >>
> >>> On Mon, 13 May 2019 at 14:21, Markus Armbruster wrote:
> Perhaps I should do it just for this file while I
On Wed, 15 May 2019 at 07:34, Markus Armbruster wrote:
>
> Jason Wang writes:
>
> > On 2019/5/14 下午8:18, Markus Armbruster wrote:
> >> -netdev's helper parameter is seriously underdocumented. Document or
> >> deprecate?
> >
> >
> > I believe management should only use fd parameter of TAP. If we
Jason Wang writes:
> On 2019/5/14 下午8:18, Markus Armbruster wrote:
>> Peter Maydell writes:
>>
>>> On Mon, 13 May 2019 at 14:21, Markus Armbruster wrote:
Perhaps I should do it just for this file while I touch it anyway. The
question to ask: should parse_acl_file() obey the locale
On 2019/5/14 下午8:18, Markus Armbruster wrote:
Peter Maydell writes:
On Mon, 13 May 2019 at 14:21, Markus Armbruster wrote:
Perhaps I should do it just for this file while I touch it anyway. The
question to ask: should parse_acl_file() obey the locale for whitespace
recognition?
I vote
On 5/14/19 2:18 PM, Markus Armbruster wrote:
> Peter Maydell writes:
>
>> On Mon, 13 May 2019 at 14:21, Markus Armbruster wrote:
>>> Perhaps I should do it just for this file while I touch it anyway. The
>>> question to ask: should parse_acl_file() obey the locale for whitespace
>>>
Peter Maydell writes:
> On Mon, 13 May 2019 at 14:21, Markus Armbruster wrote:
>> Perhaps I should do it just for this file while I touch it anyway. The
>> question to ask: should parse_acl_file() obey the locale for whitespace
>> recognition?
>
> I vote for "no".
>
> Q: do we document the
On Mon, 13 May 2019 at 14:21, Markus Armbruster wrote:
> Perhaps I should do it just for this file while I touch it anyway. The
> question to ask: should parse_acl_file() obey the locale for whitespace
> recognition?
I vote for "no".
Q: do we document the format of the ACL file anywhere ?
Philippe Mathieu-Daudé writes:
> On 4/18/19 4:53 PM, Markus Armbruster wrote:
>> parse_acl_file() passes char values to isspace(). Undefined behavior
>> when the value is negative. Not a security issue, because the
>> characters come from trusted $prefix/etc/qemu/bridge.conf and the
>> files
On 4/18/19 4:53 PM, Markus Armbruster wrote:
> parse_acl_file() passes char values to isspace(). Undefined behavior
> when the value is negative. Not a security issue, because the
> characters come from trusted $prefix/etc/qemu/bridge.conf and the
> files it includes.
>
> Fix by using
parse_acl_file() passes char values to isspace(). Undefined behavior
when the value is negative. Not a security issue, because the
characters come from trusted $prefix/etc/qemu/bridge.conf and the
files it includes.
Fix by using qemu_isspace() instead.
Signed-off-by: Markus Armbruster
---
18 matches
Mail list logo
