Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-19 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Thu, Oct 19, 2017 at 10:16:23AM +0100, Dr. David Alan Gilbert wrote: > > * Daniel P. Berrange (berra...@redhat.com) wrote: > > > On Thu, Oct 19, 2017 at 11:18:33AM +0800, Peter Xu wrote: > > > > On Wed, Oct 18, 2017 at 01:10:38PM +0100, Daniel

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-19 Thread Daniel P. Berrange
On Thu, Oct 19, 2017 at 10:16:23AM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Thu, Oct 19, 2017 at 11:18:33AM +0800, Peter Xu wrote: > > > On Wed, Oct 18, 2017 at 01:10:38PM +0100, Daniel P. Berrange wrote: > > > > On Wed, Oct 18, 2017 at 01:36:5

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-19 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Thu, Oct 19, 2017 at 11:18:33AM +0800, Peter Xu wrote: > > On Wed, Oct 18, 2017 at 01:10:38PM +0100, Daniel P. Berrange wrote: > > > On Wed, Oct 18, 2017 at 01:36:56PM +0200, Juan Quintela wrote: > > > > Peter Xu wrote: > > > > > On Wed, Oct 0

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-19 Thread Dr. David Alan Gilbert
* Peter Xu (pet...@redhat.com) wrote: > On Wed, Oct 18, 2017 at 01:10:38PM +0100, Daniel P. Berrange wrote: > > On Wed, Oct 18, 2017 at 01:36:56PM +0200, Juan Quintela wrote: > > > Peter Xu wrote: > > > > On Wed, Oct 04, 2017 at 12:39:28PM +0200, Juan Quintela wrote: > > > > > > > > [...] > > > >

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-19 Thread Daniel P. Berrange
On Thu, Oct 19, 2017 at 11:18:33AM +0800, Peter Xu wrote: > On Wed, Oct 18, 2017 at 01:10:38PM +0100, Daniel P. Berrange wrote: > > On Wed, Oct 18, 2017 at 01:36:56PM +0200, Juan Quintela wrote: > > > Peter Xu wrote: > > > > On Wed, Oct 04, 2017 at 12:39:28PM +0200, Juan Quintela wrote: > > > > >

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-18 Thread Peter Xu
On Wed, Oct 18, 2017 at 01:10:38PM +0100, Daniel P. Berrange wrote: > On Wed, Oct 18, 2017 at 01:36:56PM +0200, Juan Quintela wrote: > > Peter Xu wrote: > > > On Wed, Oct 04, 2017 at 12:39:28PM +0200, Juan Quintela wrote: > > > > > > [...] > > > > > >> +/* A simple PC boot sector that modifies mem

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-18 Thread Daniel P. Berrange
On Wed, Oct 18, 2017 at 01:49:42PM +0100, Dr. David Alan Gilbert wrote: > * Daniel P. Berrange (berra...@redhat.com) wrote: > > On Wed, Oct 04, 2017 at 12:39:28PM +0200, Juan Quintela wrote: > > > Signed-off-by: Juan Quintela > > > --- > > > tests/Makefile.include | 3 + > > > tests/migration-t

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-18 Thread Dr. David Alan Gilbert
* Daniel P. Berrange (berra...@redhat.com) wrote: > On Wed, Oct 04, 2017 at 12:39:28PM +0200, Juan Quintela wrote: > > Signed-off-by: Juan Quintela > > --- > > tests/Makefile.include | 3 + > > tests/migration-test.c | 497 > > + > > 2 files chan

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-18 Thread Daniel P. Berrange
On Wed, Oct 18, 2017 at 01:36:56PM +0200, Juan Quintela wrote: > Peter Xu wrote: > > On Wed, Oct 04, 2017 at 12:39:28PM +0200, Juan Quintela wrote: > > > > [...] > > > >> +/* A simple PC boot sector that modifies memory (1-100MB) quickly > >> + * outputing a 'B' every so often if it's still runnin

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-18 Thread Daniel P. Berrange
On Wed, Oct 04, 2017 at 12:39:28PM +0200, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 3 + > tests/migration-test.c | 497 > + > 2 files changed, 500 insertions(+) > create mode 100644 tests/migration-tes

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-18 Thread Juan Quintela
Peter Xu wrote: > On Wed, Oct 04, 2017 at 12:39:28PM +0200, Juan Quintela wrote: > > [...] > > (having some unit tests for migration is really good...) > >> +static void test_precopy(const char *uri) >> +{ >> +QTestState *from, *to; >> + >> +test_migrate_start(&from, &to, uri); >> + >> +

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-18 Thread Juan Quintela
Peter Xu wrote: > On Wed, Oct 04, 2017 at 12:39:28PM +0200, Juan Quintela wrote: > > [...] > >> +/* A simple PC boot sector that modifies memory (1-100MB) quickly >> + * outputing a 'B' every so often if it's still running. >> + */ >> +unsigned char bootsect[] = { >> + 0xfa, 0x0f, 0x01, 0x16, 0x7

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-17 Thread Peter Xu
On Wed, Oct 04, 2017 at 12:39:28PM +0200, Juan Quintela wrote: [...] > +/* A simple PC boot sector that modifies memory (1-100MB) quickly > + * outputing a 'B' every so often if it's still running. > + */ > +unsigned char bootsect[] = { > + 0xfa, 0x0f, 0x01, 0x16, 0x74, 0x7c, 0x66, 0xb8, 0x01, 0

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-16 Thread Dr. David Alan Gilbert
* Juan Quintela (quint...@redhat.com) wrote: > Signed-off-by: Juan Quintela 1) I think I agree with the bits about needing to share this code with postcopy; lets see how it goes. 2) I do have a bug I can reproduce in the postcopy test where it fails under heavy load (e.g. ~10 TCG'd guests on one

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-09 Thread Peter Xu
On Wed, Oct 04, 2017 at 12:39:28PM +0200, Juan Quintela wrote: [...] (having some unit tests for migration is really good...) > +static void test_precopy(const char *uri) > +{ > +QTestState *from, *to; > + > +test_migrate_start(&from, &to, uri); > + > +/* We want to pick a speed slow

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-04 Thread Eric Blake
On 10/04/2017 05:39 AM, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 3 + > tests/migration-test.c | 497 > + > 2 files changed, 500 insertions(+) > create mode 100644 tests/migration-test.c New file; sho

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-04 Thread Thomas Huth
On 04.10.2017 14:46, Juan Quintela wrote: > Thomas Huth wrote: >> On 04.10.2017 12:39, Juan Quintela wrote: >>> Signed-off-by: Juan Quintela > >> >> Looks like a lot of this code is the same or very similar to the code in >> postcopy-test.c ... would it make sense to factor-out that code there >

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-04 Thread Juan Quintela
Thomas Huth wrote: > On 04.10.2017 12:39, Juan Quintela wrote: >> Signed-off-by: Juan Quintela > > Looks like a lot of this code is the same or very similar to the code in > postcopy-test.c ... would it make sense to factor-out that code there > into a separate file that could be used by both te

Re: [Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-04 Thread Thomas Huth
On 04.10.2017 12:39, Juan Quintela wrote: > Signed-off-by: Juan Quintela > --- > tests/Makefile.include | 3 + > tests/migration-test.c | 497 > + > 2 files changed, 500 insertions(+) > create mode 100644 tests/migration-test.c > > diff --git a

[Qemu-devel] [PATCH 1/6] tests: Add basic migration precopy test

2017-10-04 Thread Juan Quintela
Signed-off-by: Juan Quintela --- tests/Makefile.include | 3 + tests/migration-test.c | 497 + 2 files changed, 500 insertions(+) create mode 100644 tests/migration-test.c diff --git a/tests/Makefile.include b/tests/Makefile.include index abc670