Am 08.03.2013 12:56, schrieb Kevin Wolf:
> Am 08.03.2013 um 12:46 hat Peter Lieven geschrieben:
>>
>> Am 08.03.2013 um 10:35 schrieb Kevin Wolf :
>>
>>> Am 08.03.2013 um 10:23 hat Paolo Bonzini geschrieben:
Il 08/03/2013 08:53, Peter Lieven ha scritto:
>>
>> I think the fix is to only
Am 08.03.2013 um 12:46 hat Peter Lieven geschrieben:
>
> Am 08.03.2013 um 10:35 schrieb Kevin Wolf :
>
> > Am 08.03.2013 um 10:23 hat Paolo Bonzini geschrieben:
> >> Il 08/03/2013 08:53, Peter Lieven ha scritto:
>
> I think the fix is to only call it for the monitor command. Optionall
Am 08.03.2013 um 10:35 schrieb Kevin Wolf :
> Am 08.03.2013 um 10:23 hat Paolo Bonzini geschrieben:
>> Il 08/03/2013 08:53, Peter Lieven ha scritto:
I think the fix is to only call it for the monitor command. Optionally,
when shrinking, assert that there are no requests in flight
Am 08.03.2013 um 10:23 hat Paolo Bonzini geschrieben:
> Il 08/03/2013 08:53, Peter Lieven ha scritto:
> >>
> >> I think the fix is to only call it for the monitor command. Optionally,
> >> when shrinking, assert that there are no requests in flight.
> >
> > Okay.
> >
> > What is the plan? just f
Il 08/03/2013 08:53, Peter Lieven ha scritto:
>>
>> I think the fix is to only call it for the monitor command. Optionally,
>> when shrinking, assert that there are no requests in flight.
>
> Okay.
>
> What is the plan? just fix this or fix the whole thing (which seems to
> be some
> work).
>
>
On 07.03.2013 17:09, Paolo Bonzini wrote:
Il 07/03/2013 09:53, Peter Lieven ha scritto:
Then we can add bdrv_revalidate and, for block_resize, call
bdrv_revalidate+bdrv_truncate. For bs->growable = 0 &&
!bs->drv->bdrv_truncate, bdrv_truncate can just check that the actual
size is the same or b
Il 07/03/2013 09:50, Kevin Wolf ha scritto:
> Am 06.03.2013 um 21:39 hat Paolo Bonzini geschrieben:
>> Il 06/03/2013 20:03, Peter Lieven ha scritto:
>>> Am 06.03.2013 19:48, schrieb Jeff Cody:
On Wed, Mar 06, 2013 at 07:31:51PM +0100, Paolo Bonzini wrote:
> Il 06/03/2013 19:14, Jeff Cody h
Il 07/03/2013 09:53, Peter Lieven ha scritto:
>>
>> Then we can add bdrv_revalidate and, for block_resize, call
>> bdrv_revalidate+bdrv_truncate. For bs->growable = 0 &&
>> !bs->drv->bdrv_truncate, bdrv_truncate can just check that the actual
>> size is the same or bigger as the one requested, and
Am 07.03.2013 um 11:00 schrieb Kevin Wolf :
> Am 07.03.2013 um 10:25 hat Peter Lieven geschrieben:
>>
>> Am 07.03.2013 um 10:22 schrieb Kevin Wolf :
>>
>>> Am 07.03.2013 um 10:16 hat Peter Lieven geschrieben:
>> If bs->growable is 1 for all drivers, whats the fix status of
>> CVE-2008-
Am 07.03.2013 um 10:25 hat Peter Lieven geschrieben:
>
> Am 07.03.2013 um 10:22 schrieb Kevin Wolf :
>
> > Am 07.03.2013 um 10:16 hat Peter Lieven geschrieben:
> If bs->growable is 1 for all drivers, whats the fix status of
> CVE-2008-0928? This
> flag was introduced as a fix for
Am 07.03.2013 um 10:22 schrieb Kevin Wolf :
> Am 07.03.2013 um 10:16 hat Peter Lieven geschrieben:
If bs->growable is 1 for all drivers, whats the fix status of
CVE-2008-0928? This
flag was introduced as a fix for this problem.
bdrv_check_byte_request() does nothing use
Am 07.03.2013 um 10:16 hat Peter Lieven geschrieben:
> >> If bs->growable is 1 for all drivers, whats the fix status of
> >> CVE-2008-0928? This
> >> flag was introduced as a fix for this problem.
> >>
> >> bdrv_check_byte_request() does nothing useful if bs->growable is 1.
> >
> > Don't ignore
Am 07.03.2013 um 10:03 schrieb Kevin Wolf :
> Am 07.03.2013 um 09:56 hat Peter Lieven geschrieben:
>> On 07.03.2013 09:50, Kevin Wolf wrote:
>>> Am 06.03.2013 um 21:39 hat Paolo Bonzini geschrieben:
Il 06/03/2013 20:03, Peter Lieven ha scritto:
> Am 06.03.2013 19:48, schrieb Jeff Cody:
>
Am 07.03.2013 um 09:56 hat Peter Lieven geschrieben:
> On 07.03.2013 09:50, Kevin Wolf wrote:
> >Am 06.03.2013 um 21:39 hat Paolo Bonzini geschrieben:
> >>Il 06/03/2013 20:03, Peter Lieven ha scritto:
> >>>Am 06.03.2013 19:48, schrieb Jeff Cody:
> On Wed, Mar 06, 2013 at 07:31:51PM +0100, Paolo
Am 07.03.2013 um 09:53 hat Peter Lieven geschrieben:
> On 06.03.2013 21:39, Paolo Bonzini wrote:
> >Il 06/03/2013 20:03, Peter Lieven ha scritto:
> >>Am 06.03.2013 19:48, schrieb Jeff Cody:
> >>>On Wed, Mar 06, 2013 at 07:31:51PM +0100, Paolo Bonzini wrote:
> Il 06/03/2013 19:14, Jeff Cody ha s
Am 06.03.2013 um 19:27 hat Peter Lieven geschrieben:
> Am 06.03.2013 19:06, schrieb Paolo Bonzini:
> > Il 06/03/2013 18:50, Peter Lieven ha scritto:
> Commit 9a665b2b made bdrv_truncate() call bdrv_drain_all(), but this
> breaks
> QCOW images, as well other future image formats (suc
On 07.03.2013 09:50, Kevin Wolf wrote:
Am 06.03.2013 um 21:39 hat Paolo Bonzini geschrieben:
Il 06/03/2013 20:03, Peter Lieven ha scritto:
Am 06.03.2013 19:48, schrieb Jeff Cody:
On Wed, Mar 06, 2013 at 07:31:51PM +0100, Paolo Bonzini wrote:
Il 06/03/2013 19:14, Jeff Cody ha scritto:
QCOW br
On 06.03.2013 21:39, Paolo Bonzini wrote:
Il 06/03/2013 20:03, Peter Lieven ha scritto:
Am 06.03.2013 19:48, schrieb Jeff Cody:
On Wed, Mar 06, 2013 at 07:31:51PM +0100, Paolo Bonzini wrote:
Il 06/03/2013 19:14, Jeff Cody ha scritto:
QCOW breaks with it using a normal raw posix file as a devi
Am 06.03.2013 um 21:39 hat Paolo Bonzini geschrieben:
> Il 06/03/2013 20:03, Peter Lieven ha scritto:
> > Am 06.03.2013 19:48, schrieb Jeff Cody:
> >> On Wed, Mar 06, 2013 at 07:31:51PM +0100, Paolo Bonzini wrote:
> >>> Il 06/03/2013 19:14, Jeff Cody ha scritto:
> QCOW breaks with it using a n
Il 06/03/2013 20:03, Peter Lieven ha scritto:
> Am 06.03.2013 19:48, schrieb Jeff Cody:
>> On Wed, Mar 06, 2013 at 07:31:51PM +0100, Paolo Bonzini wrote:
>>> Il 06/03/2013 19:14, Jeff Cody ha scritto:
QCOW breaks with it using a normal raw posix file as a device. As a
test: qemu-img crea
Il 06/03/2013 19:32, Jeff Cody ha scritto:
> On Wed, Mar 06, 2013 at 06:50:56PM +0100, Peter Lieven wrote:
>> Looking at the source I have not found a place where bs->growable is set to
>> 0 for any
>> block driver, maybe I miss something. Having bs->growable for iSCSI would
>> also be ok.
>>
>>
Il 06/03/2013 18:50, Peter Lieven ha scritto:
>> > Commit 9a665b2b made bdrv_truncate() call bdrv_drain_all(), but this breaks
>> > QCOW images, as well other future image formats (such as VHDX) that may
>> > call
>> > bdrv_truncate(bs->file) from within a read/write operation. For example,
>> >
Am 06.03.2013 19:48, schrieb Jeff Cody:
> On Wed, Mar 06, 2013 at 07:31:51PM +0100, Paolo Bonzini wrote:
>> Il 06/03/2013 19:14, Jeff Cody ha scritto:
>>> QCOW breaks with it using a normal raw posix file as a device. As a
>>> test: qemu-img create -f qcow test.qcow 5G. Now run qemu with that
>>>
On Wed, Mar 06, 2013 at 07:31:51PM +0100, Paolo Bonzini wrote:
> Il 06/03/2013 19:14, Jeff Cody ha scritto:
> > QCOW breaks with it using a normal raw posix file as a device. As a
> > test: qemu-img create -f qcow test.qcow 5G. Now run qemu with that
> > drive mounted, and try to partition and fo
Il 06/03/2013 19:14, Jeff Cody ha scritto:
> QCOW breaks with it using a normal raw posix file as a device. As a
> test: qemu-img create -f qcow test.qcow 5G. Now run qemu with that
> drive mounted, and try to partition and format it. QEMU now asserts.
>
> The nicety of being able to using trun
On Wed, Mar 06, 2013 at 06:50:56PM +0100, Peter Lieven wrote:
> Am 06.03.2013 15:47, schrieb Jeff Cody:
> > Commit 9a665b2b made bdrv_truncate() call bdrv_drain_all(), but this breaks
> > QCOW images, as well other future image formats (such as VHDX) that may call
> > bdrv_truncate(bs->file) from w
Am 06.03.2013 15:47, schrieb Jeff Cody:
> Commit 9a665b2b made bdrv_truncate() call bdrv_drain_all(), but this breaks
> QCOW images, as well other future image formats (such as VHDX) that may call
> bdrv_truncate(bs->file) from within a read/write operation. For example, QCOW
> will cause an asser
On Wed, Mar 06, 2013 at 07:06:24PM +0100, Paolo Bonzini wrote:
> Il 06/03/2013 18:50, Peter Lieven ha scritto:
> >> > Commit 9a665b2b made bdrv_truncate() call bdrv_drain_all(), but this
> >> > breaks
> >> > QCOW images, as well other future image formats (such as VHDX) that may
> >> > call
> >>
Am 06.03.2013 19:42, schrieb Jeff Cody:
> On Wed, Mar 06, 2013 at 07:25:39PM +0100, Peter Lieven wrote:
>> Am 06.03.2013 19:14, schrieb Jeff Cody:
>>> On Wed, Mar 06, 2013 at 07:06:24PM +0100, Paolo Bonzini wrote:
Il 06/03/2013 18:50, Peter Lieven ha scritto:
>>> Commit 9a665b2b made bdrv_
Am 06.03.2013 19:06, schrieb Paolo Bonzini:
> Il 06/03/2013 18:50, Peter Lieven ha scritto:
Commit 9a665b2b made bdrv_truncate() call bdrv_drain_all(), but this breaks
QCOW images, as well other future image formats (such as VHDX) that may
call
bdrv_truncate(bs->file) from with
Commit 9a665b2b made bdrv_truncate() call bdrv_drain_all(), but this breaks
QCOW images, as well other future image formats (such as VHDX) that may call
bdrv_truncate(bs->file) from within a read/write operation. For example, QCOW
will cause an assert, due to tracked_requests not being empty (sinc
31 matches
Mail list logo