Re: [Qemu-devel] [PATCH 1/8] tls: require compiler support for __thread

2015-04-29 Thread Paolo Bonzini
On 28/04/2015 23:04, Emilio G. Cota wrote: > > commit ad45e590025c1197a7aef5164e1ae174894b0969 > Author: Emilio G. Cota > Date: Tue Apr 28 16:54:44 2015 -0400 > > configure: require __thread support > > The codebase doesn't build without __thread support. > Formalise this re

Re: [Qemu-devel] [PATCH 1/8] tls: require compiler support for __thread

2015-04-28 Thread Emilio G. Cota
On Tue, Jan 13, 2015 at 22:07:19 +, Peter Maydell wrote: > On 13 January 2015 at 20:27, Paolo Bonzini wrote: > > On 13/01/2015 21:00, Peter Maydell wrote: > >> Hmm. That's a chunk of users who are now going to have to > >> change the way they've been building QEMU. Does configure > >> at least

Re: [Qemu-devel] [PATCH 1/8] tls: require compiler support for __thread

2015-01-13 Thread Peter Maydell
On 13 January 2015 at 20:27, Paolo Bonzini wrote: > On 13/01/2015 21:00, Peter Maydell wrote: >> Hmm. That's a chunk of users who are now going to have to >> change the way they've been building QEMU. Does configure >> at least blow up on the old gcc, or will we just silently >> build a non-workin

Re: [Qemu-devel] [PATCH 1/8] tls: require compiler support for __thread

2015-01-13 Thread Paolo Bonzini
On 13/01/2015 21:00, Peter Maydell wrote: > Hmm. That's a chunk of users who are now going to have to > change the way they've been building QEMU. Does configure > at least blow up on the old gcc, or will we just silently > build a non-working QEMU? At least the build, if not configure, should b

Re: [Qemu-devel] [PATCH 1/8] tls: require compiler support for __thread

2015-01-13 Thread Peter Maydell
On 13 January 2015 at 19:48, Paolo Bonzini wrote: > It's in the pull request. That was sneaky :-) > Native TLS is supported by all platforms except Windows and, I think, > OpenBSD, which will have to use GCC's emulated TLS. For Windows we > already do. OpenBSD ports will have to use a new-enou

Re: [Qemu-devel] [PATCH 1/8] tls: require compiler support for __thread

2015-01-13 Thread Paolo Bonzini
On 13/01/2015 19:40, Peter Maydell wrote: > On 13 January 2015 at 17:52, Paolo Bonzini wrote: >> The block layer is now using __thread unconditionally. > > Where? I did a quick grep for __thread and (other than stuff in > the *-user code and some Win32 specific files) there's no use of > __thre

Re: [Qemu-devel] [PATCH 1/8] tls: require compiler support for __thread

2015-01-13 Thread Peter Maydell
On 13 January 2015 at 17:52, Paolo Bonzini wrote: > The block layer is now using __thread unconditionally. Where? I did a quick grep for __thread and (other than stuff in the *-user code and some Win32 specific files) there's no use of __thread outside the DEFINE_TLS wrappers. > Remove the > "f

[Qemu-devel] [PATCH 1/8] tls: require compiler support for __thread

2015-01-13 Thread Paolo Bonzini
The block layer is now using __thread unconditionally. Remove the "fake" TLS wrappers (that actually aren't TLS on !Linux) in include/qemu/tls.h, and add a testcase. Signed-off-by: Paolo Bonzini --- configure | 9 +- exec.c | 2 +- include/qemu/tls.h | 52