Re: [Qemu-devel] [PATCH 11/11] i2c: Drop FROM_I2C_SLAVE() macro

2014-02-09 Thread Andreas Färber
Am 09.02.2014 02:53, schrieb Peter Crosthwaite: > On Sat, Feb 1, 2014 at 12:34 AM, Andreas Färber wrote: >> Use type-specific QOM cast macros instead. >> > > Should be past tense - "We now use type-specific ...". The imperative > form of "use" suggests you are making the change in this patch but

Re: [Qemu-devel] [PATCH 11/11] i2c: Drop FROM_I2C_SLAVE() macro

2014-02-08 Thread Peter Crosthwaite
On Sat, Feb 1, 2014 at 12:34 AM, Andreas Färber wrote: > Use type-specific QOM cast macros instead. > Should be past tense - "We now use type-specific ...". The imperative form of "use" suggests you are making the change in this patch but you have already done it. > Signed-off-by: Andreas Färber

[Qemu-devel] [PATCH 11/11] i2c: Drop FROM_I2C_SLAVE() macro

2014-01-31 Thread Andreas Färber
Use type-specific QOM cast macros instead. Signed-off-by: Andreas Färber --- include/hw/i2c/i2c.h | 2 -- 1 file changed, 2 deletions(-) diff --git a/include/hw/i2c/i2c.h b/include/hw/i2c/i2c.h index 9df987b..4986ebc 100644 --- a/include/hw/i2c/i2c.h +++ b/include/hw/i2c/i2c.h @@ -59,8 +59,6 @@