Re: [Qemu-devel] [PATCH 12/17] ppc: Fix writing to AMR/UAMOR

2016-03-15 Thread Cédric Le Goater
On 03/14/2016 09:26 PM, Thomas Huth wrote: >> > @@ -8093,7 +8137,7 @@ static void init_proc_book3s_64(CPUPPCState *env, >> > int version) >> > case BOOK3S_CPU_POWER7: >> > case BOOK3S_CPU_POWER8: >> > gen_spr_book3s_ids(env); >> > -gen_spr_amr(env); >> > +gen_spr

Re: [Qemu-devel] [PATCH 12/17] ppc: Fix writing to AMR/UAMOR

2016-03-14 Thread Thomas Huth
On 14.03.2016 17:56, Cédric Le Goater wrote: > From: Benjamin Herrenschmidt > > The masks weren't chosen nor applied properly. The architecture specifies > that writes to AMR are masked by UAMOR for PR=1, otherwise AMOR for HV=0. > > The writes to UAMOR are masked by AMOR for HV=0 > > Signed-of

[Qemu-devel] [PATCH 12/17] ppc: Fix writing to AMR/UAMOR

2016-03-14 Thread Cédric Le Goater
From: Benjamin Herrenschmidt The masks weren't chosen nor applied properly. The architecture specifies that writes to AMR are masked by UAMOR for PR=1, otherwise AMOR for HV=0. The writes to UAMOR are masked by AMOR for HV=0 Signed-off-by: Benjamin Herrenschmidt [clg: fixed gen_spr_amr() call